From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 195393858C50 for ; Fri, 21 Apr 2023 13:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 195393858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-763ae18986cso1104939f.3 for ; Fri, 21 Apr 2023 06:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1682082053; x=1684674053; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qkLzmc91NNIsntdCHSjZVpqUDAAEmRfuKqPVKx/YlaM=; b=JfEKDQ691iec5Vjhnnhe953F13Ogu+H0ZSPGZ2ftj/gHydVZieMVIHQS7Rrn1nn+Fq oAy2Z+NtzpZPr8uGeS8DrZ6RXr6XlaiFwHoJh2gjIy3cIubOt45d2yA9qh8fCpEvBPVp do7JL2Sqyno7Cdj09e06XWiBhEfrty2UF8Oahc4kp7pN9dh6V95xSt3tqq2p76g0v7qv dAX8o+Ashw2fqqXS0WK1jJs/qoG/WdPnsEZHVgS9Ld1n5+PkHW2jlHOXQpbWIUN5ke4h zK4qpOYFCK70SWTvxLqipZmsaH0qNQRujTkYiYbhanP6Vh3HgjYTBjvonv4TqbPs+Dk+ pZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682082053; x=1684674053; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qkLzmc91NNIsntdCHSjZVpqUDAAEmRfuKqPVKx/YlaM=; b=lTaoFmEHMvR7bumCEFWwmxzT60D85lcYDYBqx0eg2Z8ULgSpirZw4EEg/hPwx85qGG RmLd1QAxqP1pMu7k/Rpnl92PPtYVZebc+/y3xhhhDChmdaKrcKvkL/a8T6mPS8u4qBna K0ieaK1mZhuaC+POMLVrdhPfjoaOT2/3sFMqzJu5b3enH+6C2LRQ2EFZWa+oweUTBD+n RO4ZQQY2ScFKmMwJi3qPM6Sp3JQfa42SmVaoDFj8QwktMVmbSyvmW4p+YRBvbEYPOHUK CXCI7rPCM2pYEuBUv2yzQI68xFIXUFjvasRHTQom8ORw0fRHUmi+kZ/rFJ/bLm8HCQ0u Y9+w== X-Gm-Message-State: AAQBX9fSQz6TJ2JwGlFD2hT+lm0BJaS7IWK/xGVIHH96RFpUAkRhPNBO k6UaPuWWpGIrneNKMCic16Fl5MZ7gNMh1lcj9qjwuA== X-Google-Smtp-Source: AKy350ZtcgJXK3c26TpJgKdI2a5cIm8234cA3olK/4w7yWqYf6Tu4UzRnHVQJh6RvBgqN2WVjzHapw== X-Received: by 2002:a6b:fc07:0:b0:753:2cc5:c8b7 with SMTP id r7-20020a6bfc07000000b007532cc5c8b7mr3407540ioh.3.1682082052992; Fri, 21 Apr 2023 06:00:52 -0700 (PDT) Received: from murgatroyd (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id v27-20020a02b09b000000b003eafd76dc3fsm1285126jah.23.2023.04.21.06.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 06:00:52 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Rewrite gdb_mpz::operator== References: <20230419150931.2047832-1-tromey@adacore.com> <119e1750-83c2-9e9f-a60a-3c14b2d6c09a@simark.ca> X-Attribution: Tom Date: Fri, 21 Apr 2023 07:00:51 -0600 In-Reply-To: <119e1750-83c2-9e9f-a60a-3c14b2d6c09a@simark.ca> (Simon Marchi's message of "Wed, 19 Apr 2023 12:23:18 -0400") Message-ID: <875y9p2xvg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> It's a bit hard to understand what the intent is, if you don't know the Simon> problematic already. Could you add a comment explaining that? Sure. Simon> Also, wouldn't it work to compare size? Like: Simon> if (sizeof (T) <= sizeof (long)) Yeah, though I was concerned that the compiler might emit warnings about always-true conditions in this case. Tom