From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>, Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH] Avoid double-free with debuginfod
Date: Thu, 13 Apr 2023 14:00:07 -0600 [thread overview]
Message-ID: <875y9z5z94.fsf@tromey.com> (raw)
In-Reply-To: <afb373ad-afaf-ea4a-79be-9fd451881cdd@simark.ca> (Simon Marchi via Gdb-patches's message of "Tue, 13 Dec 2022 16:32:29 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29257
Simon> I don't know how the debuginfo tests in our testsuite work... would it
Simon> be easy to make a test that mimics the reproduction steps given in the
Simon> bug? You would build an executable without debug info, then make an
Simon> empty file with the approrpriate name in the debuginfod cache.
I finally found some time to try this today. I worked on it for a while
but couldn't get it working in a reasonable way.
>> +extern gdb_bfd_ref_ptr symfile_bfd_open_no_error (const char *);
Simon> Maybe mark the function noexcept?
I did this. I'm checking it in now.
Tom
prev parent reply other threads:[~2023-04-13 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 18:38 Tom Tromey
2022-12-13 21:32 ` Simon Marchi
2023-04-13 20:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9z5z94.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).