From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2488B3858D38 for ; Fri, 10 Mar 2023 22:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2488B3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678486133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VXIPRXI2FqLbCs2CW2YTT6or96xC4dfNjLas3xlh4X4=; b=gFr2Ab47fHyqwF3dpiXhcmRSfkTa4UgZn908mAPdtFmPcoLCzoYM4B7IGAesqY6ymRiyHJ lZ8GvjbF4Aikwv2gBeSoO2L9K50qQOPivByWyBFjFpzKyM4BPoQHh6Xi/EIah3aX4RNCtu uKEmrrGNjCSYABHtfk63tBZF87ikk74= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-Bbz0K3j8MsOpEhRvaAS7Pg-1; Fri, 10 Mar 2023 17:08:52 -0500 X-MC-Unique: Bbz0K3j8MsOpEhRvaAS7Pg-1 Received: by mail-wm1-f70.google.com with SMTP id m28-20020a05600c3b1c00b003e7d4662b83so4485063wms.0 for ; Fri, 10 Mar 2023 14:08:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678486131; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VXIPRXI2FqLbCs2CW2YTT6or96xC4dfNjLas3xlh4X4=; b=uD6nqIDYZasMOn5KbYdt+aCaUgr9P98ljGRhyc3Q5KCNXYi3ByxooIMRgv6DkfhtIG c2dzQ/SabSS4BXe+RwUb2TFGsnRIMR1kkdJMSpc8/8FUuqZnrnfQbv6KL82pYDoP5s+8 MHO9VzHKtwBuLqwBBqAhzR4MvDJEKlmin91hP5r0g6k/LufemgUZXdADVFQi2WDPTPiW yJqntoIKTWqkr9pnrpqdy2UGFqMYNoRksmHfkMf1TCCNG314nX7JzHsmdbQQC8gMQXPD T8YcNifzX6qcwteK5zNkkYycoBBbn1vsRN6RuueYpxJvyuxo9sav0Ai4WYB4cXTYj2nA 3hfg== X-Gm-Message-State: AO0yUKXulirLpWDXpcZVL/zDuOKCLAiz9m13WlndzlUREns7yexMdekf /jdT4RoKCf0r6Ah3f5ha+XS5toL0AygdvaLxLsYszN3wSKAIHHZ7Rx9sYxW35+rAmbH+KqyMbCD WmdttN9ZafUYwR90iI7bpAO1gsrVKaA== X-Received: by 2002:a05:6000:110f:b0:2cb:5f2a:274e with SMTP id z15-20020a056000110f00b002cb5f2a274emr18261443wrw.41.1678486131265; Fri, 10 Mar 2023 14:08:51 -0800 (PST) X-Google-Smtp-Source: AK7set8bIE8qPmJtV1iDN66EYdJD3KCjf36W4hoKphVOQ6w2kDEBHxnesuOv4+Sr9Rgm7xa06S9qcA== X-Received: by 2002:a05:6000:110f:b0:2cb:5f2a:274e with SMTP id z15-20020a056000110f00b002cb5f2a274emr18261430wrw.41.1678486130996; Fri, 10 Mar 2023 14:08:50 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id c17-20020adffb11000000b002c592535839sm772866wrr.17.2023.03.10.14.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 14:08:50 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 08/10] gdb: have value_as_address call unpack_pointer In-Reply-To: <87wn3olj71.fsf@tromey.com> References: <312bba523f1d5701df37f3c7984c1b18fc4b5f9d.1678460067.git.aburgess@redhat.com> <87wn3olj71.fsf@tromey.com> Date: Fri, 10 Mar 2023 22:08:48 +0000 Message-ID: <875yb8gsy7.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> +/* Extract a value as a C pointer. Does not deallocate the value. */ > > I think that 'deallocate' sentence can be removed. > I don't know when that was last relevant, values are essentially never > deallocated by hand. Thanks, have updated the comment in my local tree to read: /* Extract a value as a C pointer. */ Thanks, Andrew