From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id CE04A3858D28 for ; Sun, 26 Feb 2023 17:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE04A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id B274C1005DDA4 for ; Sun, 26 Feb 2023 17:36:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id WKwtp6LwfNX2aWKwtppJTo; Sun, 26 Feb 2023 17:36:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63fb98a3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=uMrPDfTbB2AXj5AbwzgA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KQYDDDH4Goe+TOlPk+2hNj81QkdBWPQ6jmJLOZDuBeM=; b=DzgT2l5N1dYm4gwcz8A4sZJxue 0WN5my7AmLD/rSjfnleIEXOkHeVQLaEcRWvqUDWO4didqXWbp/az0sffspXWZsUJdUxR01Sd7hjig YvBSJ9PxtKCZKxgkWq7LWUH7G; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:48904 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pWKwt-003OgR-5j; Sun, 26 Feb 2023 10:36:35 -0700 From: Tom Tromey To: Alexandra =?utf-8?B?SMOhamtvdsOh?= via Gdb-patches Cc: Alexandra =?utf-8?B?SMOhamtvdsOh?= Subject: Re: [PATCH v2] Use styled_string when defering warnings when loading separate debug files References: <20230216195604.2685177-1-ahajkova@redhat.com> <20230217123547.2737612-1-ahajkova@redhat.com> X-Attribution: Tom Date: Sun, 26 Feb 2023 10:36:31 -0700 In-Reply-To: <20230217123547.2737612-1-ahajkova@redhat.com> ("Alexandra =?utf-8?B?SMOhamtvdsOh?= via Gdb-patches"'s message of "Fri, 17 Feb 2023 13:35:47 +0100") Message-ID: <875yboz5uo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pWKwt-003OgR-5j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:48904 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Alexandra" =3D=3D Alexandra H=C3=A1jkov=C3=A1 via Gdb-patches writes: Alexandra> This improves commit 6647f05df023b63bbe056e9167e9e234172fa2ca, t= he Alexandra> filenames used in the warnings are styled properly now. =20 Alexandra> +/* Use callbacks to produce the warnings. */ Alexandra> + Alexandra> +static void Alexandra> +add_warning (warnings_vec *vec, std::string filename) Alexandra> +{ Alexandra> + vec->emplace_back ([filename] () { Alexandra> + warning (_("\"%ps\": separate debug info file has no deb= ug info"), Alexandra> + styled_string (file_name_style.style (), Alexandra> + filename.c_str())); Alexandra> + }); This works but it seems like it would be a lot simpler to just use a ui_file rather than introduce a vector of callback functions that emit warnings. Tom