From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B5C4B3857C45 for ; Sat, 25 Feb 2023 11:08:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5C4B3857C45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677323285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3sLvNppaYK7P0WI4+D5ur27orXudLLrVcS32ZXWJCjc=; b=e/v43ZFGfY0mA/w4HYKZoVFCUrTtq0L7z8b2xuAgYithifMIucpjD5WzT4JQhVh3otJ4dK fnGO6ppUssTKymyYlaVlE0XOr9/Lo06DTUuuaGxsfydQ41RB/Q0sSv+j30/ghI3Oo6/roa Z+RPiiVKyvia7Z4cZ4ELZmf8rh0F/KY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-482-HHjz3NfBN0WYCjgR3qVsOw-1; Sat, 25 Feb 2023 06:08:03 -0500 X-MC-Unique: HHjz3NfBN0WYCjgR3qVsOw-1 Received: by mail-wm1-f69.google.com with SMTP id t1-20020a7bc3c1000000b003dfe223de49so2508895wmj.5 for ; Sat, 25 Feb 2023 03:08:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677323282; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3sLvNppaYK7P0WI4+D5ur27orXudLLrVcS32ZXWJCjc=; b=pjY30hXm+CjsqL3sDoGhc5u/ehbC8mvnIcD+KMCUUF1xWiU3EgZSG15dJsnqKW1kfI TrJE+oIs69odiWl4hwEQcg2mtmyeMUUqGnuh7O7lGXMR45FbRtC3lyAKwEWC7sx0rgcm 62/ZovkCKuQ82xV0ClYi2NyGQW9D9SFo/WIP78QLrY2P9ckQT9w7ZrUBckgLeAIb0eKZ S4ugA0pe9+f+dcaNSvvBIudYUueZWS3Waz+GlZjFjbQibuvLn/gxxle0IU31dvTESK4n 15Zn/eq+UGtYut0kAkXU1uOApA9Ic1gS8Djz6rnEn7a35nRPfl3/gBU2s1LA4NyP9YDK DpRA== X-Gm-Message-State: AO0yUKVus1BiqoF5VPWDFC4DLgl1R67a6eVatplU5zOY4M2//7kjrfcs zZPeGRljNOxGrebu8pONoNhexw2fJXNZ+qGKrjl6xnczcUab2NmLn5VlrN5GWY3dqZSif9J451/ KG3+1u6aQJbkCnvLl2BfHKf0ZGOk= X-Received: by 2002:a5d:66c5:0:b0:2bf:ee7d:5369 with SMTP id k5-20020a5d66c5000000b002bfee7d5369mr16479539wrw.59.1677323282597; Sat, 25 Feb 2023 03:08:02 -0800 (PST) X-Google-Smtp-Source: AK7set/+RJ6JVYFTyZ0OP0j018IRIqwomFJ0s59m6XWyr8sp9L603edBbasatw5dL2LDaP4g68/NGA== X-Received: by 2002:a5d:66c5:0:b0:2bf:ee7d:5369 with SMTP id k5-20020a5d66c5000000b002bfee7d5369mr16479528wrw.59.1677323282300; Sat, 25 Feb 2023 03:08:02 -0800 (PST) Received: from localhost (92.40.219.187.threembb.co.uk. [92.40.219.187]) by smtp.gmail.com with ESMTPSA id l21-20020a1c7915000000b003e21ba8684dsm2172873wme.26.2023.02.25.03.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 03:08:01 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Tankut Baris Aktemur via Gdb-patches Cc: Tankut Baris Aktemur Subject: Re: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command In-Reply-To: <87mt52hn22.fsf@tromey.com> References: <20230224140410.2647437-1-tankut.baris.aktemur@intel.com> <87mt52hn22.fsf@tromey.com> Date: Sat, 25 Feb 2023 11:08:00 +0000 Message-ID: <875ybqj94f.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Tankut" == Tankut Baris Aktemur via Gdb-patches writes: > > Tankut> Use nullptr instead of NULL and boolify two local variables in > Tankut> execute_gdb_command. > > Seems fine. > Approved-By: Tom Tromey > > Tankut> + from_tty = ((cmp == 0) ? false : true); > > I'd probably write '= cmp != 0' but this is alright. +1 from me. Please don't use: 'COND ? false : true'. Thanks, Andrew