From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1E8D13858CDB for ; Mon, 13 Feb 2023 16:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E8D13858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676304154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SEc/yCSXlG4YB89g8XP9EMT4oFnev7KKCZ4go6/vKcA=; b=OmGtFUdtVOIKf3xeDy3vL/krbyFoK+vX/naDhBfDdTQYpg21xAVEzc0ZZe2thAGTte0f3N aX6ib+x5OKHt9zIlPSgq1cDURonPKa5x1Hp82K3WPeYE/Kh3H+mKjF9BiiUz7+NhlZYqJ5 SU4dZPzgnLC1gdqixc+zBwejmN4Gdm8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-466-_yH1pTdUMS6Ow1ZCsld4vQ-1; Mon, 13 Feb 2023 11:02:33 -0500 X-MC-Unique: _yH1pTdUMS6Ow1ZCsld4vQ-1 Received: by mail-qk1-f200.google.com with SMTP id s7-20020ae9f707000000b007294677a6e8so7740109qkg.17 for ; Mon, 13 Feb 2023 08:02:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SEc/yCSXlG4YB89g8XP9EMT4oFnev7KKCZ4go6/vKcA=; b=VZhaWlBtvTFGnVVAYbSyOC/W/c6awXeKwlrmlIT53QnNFJ/BugQGBWst6Wk4QV23L0 dW6fy5exXSdnzWX0N2MAanCtExQ7Yqo4VVYkb2oSasCDEnrA7qD/QVn/VjRwWbbM2ulp BjR8c+4ivAg0M0DUWJ4T+9j7kgTou+Wz5a7bERNNt55j3pIjZC84RCA27QxmEyFWfVCz zX+E918exkvwYJjucKfvpW2UtOwCBHowxl5ZcTfUJFju1c5n95kdZoHJIPrQqTAxnI0L PBFXB7eVZCT4stRP0PbCbccUNqO1jtAYm2iQHCFUGc1g0zL0dt33rkgH5NVNTQOYN/XU q/Jw== X-Gm-Message-State: AO0yUKVB+s0UbGUx0eSn31NSy7wBGKP72BW5fMNft51tuw+FXp+ZYzfo WnxC/zfltjoLCgJvS2omv9w2VY9sSYkPZ+kJjPMvGdmQC3nLouHFuOayZukATNnYXeCDWRd8OjW c5ZlOB0K1Tv1EmctjCzpTnyOmlzQ= X-Received: by 2002:a0c:ef51:0:b0:56c:2344:a58b with SMTP id t17-20020a0cef51000000b0056c2344a58bmr23423550qvs.12.1676304152749; Mon, 13 Feb 2023 08:02:32 -0800 (PST) X-Google-Smtp-Source: AK7set9iBMD+ZsaEziU4AYDH4J8P9tM5e+d7JrcX9CHlv+y/NdqcV4k4CVSCPTVbXTrbIvfmZggF6Q== X-Received: by 2002:a0c:ef51:0:b0:56c:2344:a58b with SMTP id t17-20020a0cef51000000b0056c2344a58bmr23423522qvs.12.1676304152271; Mon, 13 Feb 2023 08:02:32 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id s63-20020a37a942000000b0071c9eea2056sm10058890qke.14.2023.02.13.08.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 08:02:31 -0800 (PST) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Fix "ptype INTERNAL_FUNC" (PR gdb/30105) In-Reply-To: <20230210233604.2228450-2-pedro@palves.net> References: <20230210233604.2228450-1-pedro@palves.net> <20230210233604.2228450-2-pedro@palves.net> Date: Mon, 13 Feb 2023 16:02:30 +0000 Message-ID: <875yc5tuy1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > Currently, looking at the type of an internal function, like below, > hits an odd error: > > (gdb) ptype $_isvoid > type = type not handled in c_type_print_varspec_prefix() > > That is an error thrown from > c-typeprint.c:c_type_print_varspec_prefix, where it reads: > > ... > case TYPE_CODE_DECFLOAT: > case TYPE_CODE_FIXED_POINT: > /* These types need no prefix. They are listed here so that > gcc -Wall will reveal any types that haven't been handled. */ > break; > default: > error (_("type not handled in c_type_print_varspec_prefix()")); > break; > > Internal function types have type code TYPE_CODE_INTERNAL_FUNCTION, > which is not explicitly handled by that switch. > > That comment quoted above says that gcc -Wall will reveal any types > that haven't been handled, but that's not actually true, at least with > modern GCCs. You would need to enable -Wswitch-enum for that, which > we don't. If I do enable that warning, then I see that we're missing > handling for the following type codes: > > TYPE_CODE_INTERNAL_FUNCTION, > TYPE_CODE_MODULE, > TYPE_CODE_NAMELIST, > TYPE_CODE_XMETHOD > > TYPE_CODE_MODULE and TYPE_CODE_NAMELIST and Fortran-specific, so it'd > be a little weird to handle them here. > > I tried to reach this code with TYPE_CODE_XMETHOD, but couldn't figure > out how to. ptype on an xmethod isn't treated specially, it just > complains that the method doesn't exist. I've extended the > gdb.python/py-xmethods.exp testcase to make sure of that. > > My thinking is that whatever type code we add next, the most likely > scenario is that it won't need any special handling, so we'd just be > adding another case to that "do nothing" list. If we do need special > casing for whatever type code, I think that tests added at the same > time as the feature would uncover it anyhow. If we do miss adding the > special casing, then it still looks better to me to print the type > somewhat incompletely than to error out and make it harder for users > to debug whatever they need. So I think that the best thing to do > here is to just remove all those explicit "do nothing" cases, along > with the error default case. > > After doing that, I decided to write a testcase that iterates over all > supported languages doing "ptype INTERNAL_FUNC". That revealed that > Pascal has a similar problem, except the default case hits a > gdb_assert instead of an error: > > (gdb) with language pascal -- ptype $_isvoid > type = > ../../src/gdb/p-typeprint.c:268: internal-error: type_print_varspec_prefix: unexpected type > A problem internal to GDB has been detected, > further debugging may prove unreliable. > > That is fixed by this patch in the same way. > > You'll notice that the new testcase special-cases the Ada expected > output: > > } elseif {$lang == "ada"} { > gdb_test "ptype \$_isvoid" "<>" > } else { > gdb_test "ptype \$_isvoid" "" > } > > That will be subject of the following patch. > > Change-Id: I81aec03523cceb338b5180a0b4c2e4ad26b4c4db > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30105 LGTM. Thanks, Andrew > --- > gdb/c-typeprint.c | 51 ------------------- > gdb/p-typeprint.c | 46 ----------------- > .../gdb.base/internal-functions-ptype.exp | 42 +++++++++++++++ > gdb/testsuite/gdb.python/py-xmethods.exp | 8 +++ > 4 files changed, 50 insertions(+), 97 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/internal-functions-ptype.exp > > diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c > index dca96231117..7e9d941a435 100644 > --- a/gdb/c-typeprint.c > +++ b/gdb/c-typeprint.c > @@ -441,31 +441,6 @@ c_type_print_varspec_prefix (struct type *type, > stream, show, passed_a_ptr, 0, > language, flags, podata); > break; > - > - case TYPE_CODE_UNDEF: > - case TYPE_CODE_STRUCT: > - case TYPE_CODE_UNION: > - case TYPE_CODE_ENUM: > - case TYPE_CODE_FLAGS: > - case TYPE_CODE_INT: > - case TYPE_CODE_FLT: > - case TYPE_CODE_VOID: > - case TYPE_CODE_ERROR: > - case TYPE_CODE_CHAR: > - case TYPE_CODE_BOOL: > - case TYPE_CODE_SET: > - case TYPE_CODE_RANGE: > - case TYPE_CODE_STRING: > - case TYPE_CODE_COMPLEX: > - case TYPE_CODE_NAMESPACE: > - case TYPE_CODE_DECFLOAT: > - case TYPE_CODE_FIXED_POINT: > - /* These types need no prefix. They are listed here so that > - gcc -Wall will reveal any types that haven't been handled. */ > - break; > - default: > - error (_("type not handled in c_type_print_varspec_prefix()")); > - break; > } > } > > @@ -821,32 +796,6 @@ c_type_print_varspec_suffix (struct type *type, > c_type_print_varspec_suffix (type->target_type (), stream, > show, passed_a_ptr, 0, language, flags); > break; > - > - case TYPE_CODE_UNDEF: > - case TYPE_CODE_STRUCT: > - case TYPE_CODE_UNION: > - case TYPE_CODE_FLAGS: > - case TYPE_CODE_ENUM: > - case TYPE_CODE_INT: > - case TYPE_CODE_FLT: > - case TYPE_CODE_VOID: > - case TYPE_CODE_ERROR: > - case TYPE_CODE_CHAR: > - case TYPE_CODE_BOOL: > - case TYPE_CODE_SET: > - case TYPE_CODE_RANGE: > - case TYPE_CODE_STRING: > - case TYPE_CODE_COMPLEX: > - case TYPE_CODE_NAMESPACE: > - case TYPE_CODE_DECFLOAT: > - case TYPE_CODE_FIXED_POINT: > - /* These types do not need a suffix. They are listed so that > - gcc -Wall will report types that may not have been > - considered. */ > - break; > - default: > - error (_("type not handled in c_type_print_varspec_suffix()")); > - break; > } > } > > diff --git a/gdb/p-typeprint.c b/gdb/p-typeprint.c > index e8542d6845a..7458aa6c095 100644 > --- a/gdb/p-typeprint.c > +++ b/gdb/p-typeprint.c > @@ -244,29 +244,6 @@ pascal_language::type_print_varspec_prefix (struct type *type, > plongest (type->bounds ()->high.const_val ())); > gdb_printf (stream, "of "); > break; > - > - case TYPE_CODE_UNDEF: > - case TYPE_CODE_STRUCT: > - case TYPE_CODE_UNION: > - case TYPE_CODE_ENUM: > - case TYPE_CODE_INT: > - case TYPE_CODE_FLT: > - case TYPE_CODE_VOID: > - case TYPE_CODE_ERROR: > - case TYPE_CODE_CHAR: > - case TYPE_CODE_BOOL: > - case TYPE_CODE_SET: > - case TYPE_CODE_RANGE: > - case TYPE_CODE_STRING: > - case TYPE_CODE_COMPLEX: > - case TYPE_CODE_TYPEDEF: > - case TYPE_CODE_FIXED_POINT: > - /* These types need no prefix. They are listed here so that > - gcc -Wall will reveal any types that haven't been handled. */ > - break; > - default: > - gdb_assert_not_reached ("unexpected type"); > - break; > } > } > > @@ -377,29 +354,6 @@ pascal_language::type_print_varspec_suffix (struct type *type, > type_print_func_varspec_suffix (type, stream, show, > passed_a_ptr, 0, flags); > break; > - > - case TYPE_CODE_UNDEF: > - case TYPE_CODE_STRUCT: > - case TYPE_CODE_UNION: > - case TYPE_CODE_ENUM: > - case TYPE_CODE_INT: > - case TYPE_CODE_FLT: > - case TYPE_CODE_VOID: > - case TYPE_CODE_ERROR: > - case TYPE_CODE_CHAR: > - case TYPE_CODE_BOOL: > - case TYPE_CODE_SET: > - case TYPE_CODE_RANGE: > - case TYPE_CODE_STRING: > - case TYPE_CODE_COMPLEX: > - case TYPE_CODE_TYPEDEF: > - case TYPE_CODE_FIXED_POINT: > - /* These types do not need a suffix. They are listed so that > - gcc -Wall will report types that may not have been considered. */ > - break; > - default: > - gdb_assert_not_reached ("unexpected type"); > - break; > } > } > > diff --git a/gdb/testsuite/gdb.base/internal-functions-ptype.exp b/gdb/testsuite/gdb.base/internal-functions-ptype.exp > new file mode 100644 > index 00000000000..42caae05aad > --- /dev/null > +++ b/gdb/testsuite/gdb.base/internal-functions-ptype.exp > @@ -0,0 +1,42 @@ > +# Copyright 2023 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test "ptype INTERNAL_FUNCTION" in all languages. > + > +proc test_ptype_internal_function {} { > + set all_languages [get_set_option_choices "set language"] > + > + foreach_with_prefix lang $all_languages { > + if { $lang == "auto" || $lang == "local" } { > + # Avoid duplicate testing. > + continue > + } > + > + gdb_test_no_output "set language $lang" > + > + if {$lang == "unknown"} { > + gdb_test "ptype \$_isvoid" \ > + "expression parsing not implemented for language \"Unknown\"" > + } elseif {$lang == "ada"} { > + gdb_test "ptype \$_isvoid" "<>" > + } else { > + gdb_test "ptype \$_isvoid" "" > + } > + } > +} > + > +clean_restart > + > +test_ptype_internal_function > diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp > index 97d560476fc..2cf7bbb68b0 100644 > --- a/gdb/testsuite/gdb.python/py-xmethods.exp > +++ b/gdb/testsuite/gdb.python/py-xmethods.exp > @@ -52,6 +52,9 @@ gdb_test "p a_geta" ".* = 1" "before: a_geta 1" > gdb_test "p ++a1" "No symbol.*" "before: ++a1" > gdb_test "p a1.getarrayind(5)" "Couldn't find method.*" \ > "before: a1.getarrayind(5)" > +gdb_test "ptype a1.getarrayind" \ > + "There is no member or method named getarrayind\\." \ > + "before: ptype a1.getarrayind" > > gdb_test "p a_ptr->geta()" ".* = 60" "before: a_ptr->geta()" > gdb_test "p b_geta" ".* = 1" "before: b_geta 1" > @@ -94,9 +97,14 @@ gdb_test "p b1 - a1" ".* = 25" "after: b1 - a1" > gdb_test "p a_minus_a" ".* = 4" "after: a_minus_a 4" > > gdb_test "p a1.geta()" "From Python .*5" "after: a1.geta()" > + > gdb_test "p ++a1" "From Python .*6" "after: ++a1" > gdb_test "p a1.getarrayind(5)" "From Python .*5" \ > "after: a1.getarrayind(5)" > +gdb_test "ptype a1.getarrayind" \ > + "There is no member or method named getarrayind\\." \ > + "after: ptype a1.getarrayind" > + > gdb_test "p a1\[6\]" ".*int &.*6" "after a1\[\]" > gdb_test "p b1\[7\]" ".*const int &.*7" "after b1\[\]" > # Note the following test. Xmethods on dynamc types are not looked up > -- > 2.36.0