From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy3-pub.mail.unifiedlayer.com (qproxy3-pub.mail.unifiedlayer.com [67.222.38.20]) by sourceware.org (Postfix) with ESMTPS id 6D75538582BD for ; Tue, 31 Jan 2023 17:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D75538582BD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by qproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id 8DFFD802B151 for ; Tue, 31 Jan 2023 17:28:09 +0000 (UTC) Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 83D0A100492AC for ; Tue, 31 Jan 2023 17:27:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id MuPzpdkEnGjYaMuPzp94M6; Tue, 31 Jan 2023 17:27:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=cdgXElPM c=1 sm=1 tr=0 ts=63d94f8b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=0TgXxMK9EqXXme3dDgAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JBZtk9+atEV8F0WxUYvDRvIsglnQRY9IePUlt/VMaQI=; b=EuXwTpSj3K4df8GbgCvLQn0QrF sunRLvU3SB+/7jNXj+itu7R6VcBOR2q1yjeWe4cwcFPXYbVeZJgiFT0bncGzzIsq3Y/adr/xKyv7/ l6iELsegfcNgfKDbXbgzTdzi4; Received: from 71-211-157-143.hlrn.qwest.net ([71.211.157.143]:57036 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMuPz-001Qke-6o; Tue, 31 Jan 2023 10:27:39 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Andrew Burgess , Simon Marchi , Simon Marchi Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump References: <20230130160337.55890-1-simon.marchi@efficios.com> <87a61zvh7a.fsf@redhat.com> <03ff1644-df3d-2e6b-f2aa-49767abc580b@polymtl.ca> <877cx3uki5.fsf@redhat.com> <92a28fac-9d20-f0be-fd7e-b9ad8683c615@polymtl.ca> X-Attribution: Tom Date: Tue, 31 Jan 2023 10:27:37 -0700 In-Reply-To: <92a28fac-9d20-f0be-fd7e-b9ad8683c615@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 31 Jan 2023 10:49:10 -0500") Message-ID: <875ycmmx6e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.157.143 X-Source-L: No X-Exim-ID: 1pMuPz-001Qke-6o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-157-143.hlrn.qwest.net (murgatroyd) [71.211.157.143]:57036 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> I think this would be a good improvement. Especially the "No debugging >> symbols found..." message now being printed, is, I think, a good thing. Simon> Although I agree with you, given Tom's answer, I will go with the simple Simon> nullptr check. Hopefully we can being back the "No debugging symbols Simon> found" message at some later point. There really is debuginfo -- it's just not usable. So I think it would be better to print a big red error saying that, because it's probably of interest to the user. Maybe "info shared" could also be augmented to share this sort of info. Tom