From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 711183858D1E for ; Mon, 30 Jan 2023 19:07:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 711183858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 99E8210048ED6 for ; Mon, 30 Jan 2023 19:07:11 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id MZUlpEdIyx7AJMZUlpjTTJ; Mon, 30 Jan 2023 19:07:11 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=WsvujfTv c=1 sm=1 tr=0 ts=63d8155f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=mar4U8W_ImjUKWRPpj8A:9 a=BPGFM6C1vxUA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iejuLlnnlwf8FBKUeKrFMvh/fIuRL8Zh6qn+t5y6P54=; b=s5WhIr8jKL/DHSuXx2edtxrbPY qoKCoBbMyqkZtG0JGySlnVUqOVncs5FgDT0Pts91YmjGyNFBizar0LbhXVctWCfHXGSQ5PwOTsi05 3jSuATOCYzpIlfdXh62XjCG49; Received: from 71-211-157-143.hlrn.qwest.net ([71.211.157.143]:51252 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMZUl-0016a6-0t; Mon, 30 Jan 2023 12:07:11 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump References: <20230130160337.55890-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 30 Jan 2023 12:07:09 -0700 In-Reply-To: <20230130160337.55890-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 30 Jan 2023 11:03:37 -0500") Message-ID: <875ycnon8i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.157.143 X-Source-L: No X-Exim-ID: 1pMZUl-0016a6-0t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-157-143.hlrn.qwest.net (murgatroyd) [71.211.157.143]:51252 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> From: Simon Marchi Simon> New in v2: Simon> - move the implementation to the cooked_index_vector class Simon> - use the gdbarch from the objfile Simon> - add some QUIT macro calls Simon> - add call to wait, to ensure the index is finished Thanks, this looks good to me. I don't really know which trailer to use but -- Approved-By: Tom Tromey Tom