From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id A91983858D28 for ; Wed, 25 Jan 2023 22:10:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A91983858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id EB7691005E3CF for ; Wed, 25 Jan 2023 22:10:08 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Kny4pVByQvm7MKny4p6Vgg; Wed, 25 Jan 2023 22:10:08 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=T4lJ89GQ c=1 sm=1 tr=0 ts=63d1a8c0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=UpAuxk3Cwbjq5YeeipkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fA8OkbmOOnZ4CSAAD3FtWTp+vx5VO7JM0R8ShkBWHfw=; b=tcAPQDckHR1xAAkAwFLCKzYTgy /bSmC4MeHtoUxXlxWnh80oP1CgRnxuQoiSeAs7+OkKXQBDYlAoYD/Js5lg7b15rYLhPNh/DO7jr4n DYhpCQXbP0paizV9uPo/p9otI; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:54302 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKny4-000Dkq-Ij; Wed, 25 Jan 2023 15:10:08 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 9/9] gdb/testsuite/dap: fix gdb.dap/basic-dap.exp disassembly test for PIE References: <20230106185729.42372-1-simon.marchi@efficios.com> <20230106185729.42372-10-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 25 Jan 2023 15:10:03 -0700 In-Reply-To: <20230106185729.42372-10-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 6 Jan 2023 13:57:29 -0500") Message-ID: <875ycutgec.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKny4-000Dkq-Ij X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:54302 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: >>>> {... {"memoryReference": "0x115d" Simon> The problem is that the PC to disassemble is taken from the breakpoint Simon> insertion response, which happens before running. With a PIE Simon> executable, that PC is unrelocated, but the disassembly request happens Simon> after relocation. This is an odd one. It isn't super clear when memory references are invalidated. (The spec doesn't even define what a memory reference is.) Simon> I chose to fix this by watching for a breakpoint changed event giving Simon> the new breakpoint address, and recording the address from there. I Simon> think this is an interesting way to fix it, because it adds a bit of Simon> test coverage, I don't think these events are checked right now. This seems pretty good to me. Simon> - Do the disassembly by symbol instead of by address. I don't think this is possible in DAP. One of the many holes. Tom