From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id DB45D3858426 for ; Tue, 10 Jan 2023 18:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB45D3858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2f.google.com with SMTP id q190so6506376iod.10 for ; Tue, 10 Jan 2023 10:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q5sf30fSVNIAfKSkluYw18X9tt8b/s7hxIfR3NOeNi8=; b=erL8s8sIABSTgDN2oCIQipVAO4L4tQpsPFAdXaEkPm0FMh/Jy8u2GWpmDhCoycnf7x kSVwSOPKldeh08gZeUJGcH41WH7/D8yU4lZVmNWa2aUFtTIbt3/3xiTgsQiCV/4C2/8A bmIWepJraEzHhwD8VQMoCCWLlfsSe+rBLeYqCPCjNciCSIi7XdElTCoRNWufFq/qx95x fYtwrnk4fM+99aZpqExUu6DqWTx0mrUjtsS1OUA2ZyH8q1ftFTL+CPzzo0/UCTDr3I0I tcn1BaW7oC1z/PCew6c3ARkXH0m+9HoYTU5/PXVK2WPsgs2GM8ADJ11R68wtBYRE/9Zb SKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q5sf30fSVNIAfKSkluYw18X9tt8b/s7hxIfR3NOeNi8=; b=Kh6I5l4hT0Y2FlJbECb5jSHbN7Fh9JKsPumPEkwLa/XtaX8tAyujQkjXq3Wqzgx7H8 /AJLhTGSStqxO67ASIm7u5KBnnO8UiGL80gd/g0NCS+csv17RQqeqMmiiAtVsjtJbcYW 7nbM9hrXq3UEAGGwy4JjIAGi5rNA7QhL/Wh3oacjQ7XXXQKLss5A242Vi9F/ecLpB+QB Rj2kFdiKaL7ze/MfvZu1Z8ABQSSB8R6xjPg2Y/Se5EdzVPpnOmraTFcmK7kE6z7IJI82 K9HL7cFye/hGujpmo0SwhwOuYhmYJ4WT30aTC+bljmRP6kVwSsk/2hvhFpmn6oOQYHMU H6ig== X-Gm-Message-State: AFqh2krrimz6iQd5hG6wtA8viK0abovyLBxnha7E0FFWV1GYX0kvOgto WZtxu+T2QSGYyYE7kRZ8axLkatvjTJRuB6y1 X-Google-Smtp-Source: AMrXdXuPzhPA48Yn0kJyIl4XY8wLwIgxOmA32SjjVOQ8Oh0wiCOhNY5V6jtdsR/0GuNp8rlVJJuRJg== X-Received: by 2002:a05:6602:3785:b0:6ea:6c79:d224 with SMTP id be5-20020a056602378500b006ea6c79d224mr56917799iob.7.1673375049139; Tue, 10 Jan 2023 10:24:09 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id b18-20020a026f52000000b0039e8f997ad6sm1401749jae.32.2023.01.10.10.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 10:24:08 -0800 (PST) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , Joel Brobecker , Tom Tromey via Gdb-patches Subject: Re: [PATCH 2/4] Don't erase empty indices in DWARF reader References: <20221215190759.2494095-1-tromey@adacore.com> <20221215190759.2494095-3-tromey@adacore.com> <878rj3zbtv.fsf@redhat.com> <87tu1rl3rh.fsf@tromey.com> <87k01vac81.fsf@tromey.com> <877cxva7x8.fsf@tromey.com> <87k01uhfda.fsf@redhat.com> X-Attribution: Tom Date: Tue, 10 Jan 2023 11:24:07 -0700 In-Reply-To: <87k01uhfda.fsf@redhat.com> (Andrew Burgess's message of "Tue, 10 Jan 2023 10:07:45 +0000") Message-ID: <875yde8czc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> If you don't believe there's any point adding an assert in its place Andrew> then I'm fine with that. Andrew> I'm always pleased to see new selftests being added, so if you feel Andrew> that's worth doing then +1 from me. Andrew> But I don't think you should drop this patch if you are happy with it, Andrew> no point in holding on to dead code. Alright. v2 will keep this and add some unit tests to the first patch. Tom