From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id ADA193858C62 for ; Thu, 5 Jan 2023 20:25:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADA193858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 28CD580317E7 for ; Thu, 5 Jan 2023 20:25:45 +0000 (UTC) Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 2132A100476C3 for ; Thu, 5 Jan 2023 20:24:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DWn7plurpNX2aDWn7pGRQQ; Thu, 05 Jan 2023 20:24:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63b7320d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NEAV23lmAAAA:8 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=TsHE4Kj7ihtrvi5Q:21 a=Sssc0LUHLJ0A:10:toolong_subject_4 a=qXd4zc3hntUA:10:shortened_url_in_subject_3 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=Byx-y9mGAAAA:8 a=SuMsPWKEpeeJjjLoabUA:9 a=PJs1k_9Uz8QA:10:uccc_2email_address a=wbPun8FewvIMPsZ9CMGT:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2iDyDcsFWDm2rOedieeFug8Z36ZBCpd7q2wJErZvPRc=; b=jy/q3tfIDRqszVBy83r3eUqCFg ek2GyZ5QkTerxatsiXXLzXcErdChfK82Y57QMLe1oVU6steODJxRmcmNcamwq1uEEhOVLNU6iJz0g y7i2vBGzjWI6YNapedzeYm7Ea; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:50112 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDWn6-004O0n-NJ; Thu, 05 Jan 2023 13:24:44 -0700 From: Tom Tromey To: Zheng Zhan Liang via Gdb-patches Cc: Zheng Zhan Liang , Zheng Zhan Subject: Re: [PATCH] I'm debugging https://github.com/helix-editor/helix.git@63dcaae1b9083396fb3faaef9eaa2421f7e48fb9, which is a editor implemented with rust lang. When I type gdb command below: (gdb) b pars gdb dumped. I got: m_match = 0x7fffd8173cc7 "parse::h3bbecc5bbd82b347" m_ignored_ranges = { first = 0x7fffd8173cbb "::parse::h3bbecc5bbd82b347", second = 0x7fffd8173cc5 "::parse::h3bbecc5bbd82b347" } References: <20230102124334.120786-1-linuxmaker@163.com> X-Attribution: Tom Date: Thu, 05 Jan 2023 13:24:42 -0700 In-Reply-To: <20230102124334.120786-1-linuxmaker@163.com> (Zheng Zhan Liang via Gdb-patches's message of "Mon, 2 Jan 2023 20:43:34 +0800") Message-ID: <875ydkd911.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDWn6-004O0n-NJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:50112 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Zheng" == Zheng Zhan Liang via Gdb-patches writes: Zheng> From: Zheng Zhan Hi. Thank you for the patch. The text all seemed to end up in the Subject line. Probably you need another newline after the first line of the commit message. Zheng> --- a/gdb/completer.h Zheng> +++ b/gdb/completer.h Zheng> @@ -163,8 +163,11 @@ class completion_match_for_lcd Zheng> const char *prev = m_match; Zheng> for (const auto &range : m_ignored_ranges) Zheng> { Zheng> - m_finished_storage.append (prev, range.first); Zheng> - prev = range.second; Zheng> + if (prev < range.first) Zheng> + { Zheng> + m_finished_storage.append (prev, range.first); Zheng> + prev = range.second; Zheng> + } Is there any way to construct a test case for this? Tom