From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id D26E03858D33 for ; Thu, 5 Jan 2023 19:52:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D26E03858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 52F9010046FF5 for ; Thu, 5 Jan 2023 19:52:58 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DWIMp0z5PSnieDWIMpKYX4; Thu, 05 Jan 2023 19:52:58 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IJ3HtijG c=1 sm=1 tr=0 ts=63b72a9a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=QyXUC8HyAAAA:8 a=1H6TpgU6eIIYg64Di-wA:9 a=JlEvGDnUVHgA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+hJMS0LDnHLY7YhZMEBVCzgtl2fyhQKgcYu+AA6fJ48=; b=BsIu9SIXTRESpYAYIcVXfnCZS5 2ay4IhGb6SqvHjsmeyomlFAqGxyQeqj+xp59yQRr9P+z4OiYsCqqK94/W/zWL2sXHQWPWpp4z8v8b LiQptyFByB2DTFs6WprntVoIS; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:42768 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDWIL-003mqQ-Ud; Thu, 05 Jan 2023 12:52:58 -0700 From: Tom Tromey To: Stephan Rohr via Gdb-patches Cc: Stephan Rohr Subject: Re: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type. References: <20221221131244.1287706-1-stephan.rohr@intel.com> <20221221131244.1287706-2-stephan.rohr@intel.com> X-Attribution: Tom Date: Thu, 05 Jan 2023 12:52:53 -0700 In-Reply-To: <20221221131244.1287706-2-stephan.rohr@intel.com> (Stephan Rohr via Gdb-patches's message of "Wed, 21 Dec 2022 14:12:44 +0100") Message-ID: <875ydkep2i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDWIL-003mqQ-Ud X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:42768 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Stephan Rohr via Gdb-patches writes: > From: "Rohr, Stephan" > The 'rw_pieced_value' function is executed when fetching a (lazy) > variable described by 'DW_OP_piece' or 'DW_OP_bit_piece'. The > function checks the 'type' and 'enclosing_type' fields of the value > for identity. Thanks for the patch. > If a lazy value is fetched, GDB allocates space based on the enclosing > type's length and typically reads the 'full' object. This is not > implemented for pieced values and causes an internal error if 'type' > and 'enclosing_type' of a value are not identical. > However, GDB can read the value based on its type. Thus, this patch > fixes the previously mentioned cases by removing the check for identity. I thought there was some other discussion & idea about the cause of this patch... something like, setting a value's type should reset the enclosing type? Or vice versa? I am wondering if you tried this approach instead. Tom