From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 296CA3858421 for ; Tue, 20 Dec 2022 21:11:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 296CA3858421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 875401004967C for ; Tue, 20 Dec 2022 21:10:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 7jsxpXNT3o5OC7jsxplL4j; Tue, 20 Dec 2022 21:10:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=EZMN/NqC c=1 sm=1 tr=0 ts=63a224db a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=KiQ1K9fgb7Ym871JrywA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nPBDpGcLZl21iYrK6/3p5C+lgtq6zrwZQOrKzDF0r5k=; b=RwOrl/uHwL9eOqqFw+g6jXcDw1 BOz5l4CcAZWypuLJNY/0F3y/UNlol/EzjBrrjPedyScF9MuDSDZgFrp9lAVu4S3BwstOIohRS+GZt dK2tgChTrbvsPNWUKZjmr9hV1; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:48542 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p7jsx-002VEs-9u; Tue, 20 Dec 2022 14:10:51 -0700 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH v3 2/2] gdb/c++: Detect ambiguous variables in imported namespaces References: <20221122113319.1760546-1-blarsen@redhat.com> <20221122113319.1760546-3-blarsen@redhat.com> X-Attribution: Tom Date: Tue, 20 Dec 2022 14:10:48 -0700 In-Reply-To: <20221122113319.1760546-3-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Tue, 22 Nov 2022 12:33:20 +0100") Message-ID: <875ye5kch3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p7jsx-002VEs-9u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:48542 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> When running gdb.cp/nsusing.cc and stopping at line 17, we can ask GDB Bruno> to print x and get a compiler-dependent answer. Using gcc 12.2.1, GDB Bruno> will print M::x, and using clang 16.0.0 prints N::x. Not only is this Bruno> behavior confusing to users, it is also not consistent with compiler Bruno> behaviors, which would warn that using x is ambiguous at this point. Thanks for the patch. Bruno> + error (_("%s"), error_str.c_str ()); Bruno> + } Bruno> + else Bruno> + return found_symbols; Bruno> + Bruno> + /* This is needed to silence a -Werror=return-type warning, because Bruno> + the above if case doesn't have a return statement. */ Bruno> + gdb_assert_not_reached (); Bruno> } This is surprising, because error is marked as noreturn. Anyway perhaps a better workaround would be to just remove the 'else'. Bruno> + /* Despite getting a map, it should have at most one element, otherwise Bruno> + cp_lookup_symbol_via_import will have already reported the ambiguity. */ Bruno> + std::map result Bruno> + = cp_lookup_symbol_via_imports (scope, name, block, domain, 0, 1, 1); I think it would be better to have some kind of wrapper, where cp_lookup_symbol_via_imports takes a set as a parameter (to avoid having to merge sets), and then the wrapper extracts the result. Maybe the error handling could be stuck in the wrapper as well. I didn't look into that. Tom