From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id B412D3858CDB for ; Wed, 21 Sep 2022 18:13:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B412D3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id D5C1D1004CA60 for ; Wed, 21 Sep 2022 18:12:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b4DLoeXJmvlAab4DLoi0is; Wed, 21 Sep 2022 18:12:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S+wcfKgP c=1 sm=1 tr=0 ts=632b5423 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=geYMgDs-UgbARDDxL4YA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5KOIAPBXkaOiIjP1XbK2dI8xIZY8k0U/cW4rKx+oRcQ=; b=mKfNeGKbdmAqlhL8WLNZ37Q1Ng eeiLSLp3W5XP3/ZUMmRygJzcZsFILP2X/7ZwVZXSlXfsClUdIIxRNVi+JURy6eIj46UGtEg4PHhkv 1gc+0dnN2dTho3TPBRzqvJMYh; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56550 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ob4DK-002URJ-H5; Wed, 21 Sep 2022 12:12:50 -0600 From: Tom Tromey To: Enze Li via Gdb-patches Cc: Enze Li , schwab@linux-m68k.org, enze.li@gmx.com Subject: Re: [PATCH v2] gdb: add a numeric check after the exponent (PR cli/24124) References: X-Attribution: Tom Date: Wed, 21 Sep 2022 12:12:45 -0600 In-Reply-To: (Enze Li via Gdb-patches's message of "Mon, 5 Sep 2022 21:57:36 +0800") Message-ID: <875yhg38bm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob4DK-002URJ-H5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56550 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 18:13:03 -0000 >>>>> Enze Li via Gdb-patches writes: > PR cli/24124 points out that `b *804874d` or `b *804874f` gives output > `Invalid number "804874d".` or `Invalid number "804874f".` And the > output of `b *804874e` is `Breakpoint 1 at 0xc480a`. Thank you for the patch. > That is to say, when "e" or "E" appears after a decimal value, it will > be incorrectly parsed as a floating point number. Importantly, this > parsing is not consistent with the C language. I suspect the change has to be in c-exp.y:parse_number, in order to support the case where the input radix is 16. In this situation, something like "80e" is a valid number. The input radix seems like a misfeature, IMNSHO, but I think people do actually use it. Tom