From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id BB33B3858C55 for ; Tue, 20 Sep 2022 20:30:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB33B3858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 25AB91004730B for ; Tue, 20 Sep 2022 20:30:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ajsdoR8tEvlAaajsfoUi3P; Tue, 20 Sep 2022 20:30:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S+wcfKgP c=1 sm=1 tr=0 ts=632a22d2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=nmtlFVffSbQaDdfd8ZEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TxFFUS1Jcx+NDLGcqJ7oVyhko549Iv2NR77z7mt7LI0=; b=nAtgP1aZ79hnMQFf2pkVmHoPIJ 4sRn12tuG/8VpOi7m2/n8FrCLguM96o4Cx88aq5219wicB3fjwX34JeS/e188Mw8uICPi44/MlQAv NLGIRoVu0IAj/db9ZidZffdaK; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56510 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oajoc-0048w9-SB; Tue, 20 Sep 2022 14:25:58 -0600 From: Tom Tromey To: Keith Seitz via Gdb-patches Cc: Jiangshuai Li , Keith Seitz Subject: Re: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c References: <20220920094515.58156-1-jiangshuai_li@linux.alibaba.com> <58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com> X-Attribution: Tom Date: Tue, 20 Sep 2022 14:25:52 -0600 In-Reply-To: <58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com> (Keith Seitz via Gdb-patches's message of "Tue, 20 Sep 2022 09:54:45 -0700") Message-ID: <875yhh6be7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1oajoc-0048w9-SB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56510 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 20:30:31 -0000 >>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> I think that cskyv2-linux.c needs to be regenerated. If I apply Keith> your patch locally, it does not give me the same file back. Keith> [I believe this is because cskyv2-linux.c was not properly generated Keith> when it was committed.] Thanks for checking this. Keith> Otherwise, LGTM, and I would encourage a maintainer to approve this. I think it's good with the problem fixed. It's important for the primary sources to be checked in. Tom