From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 2EC403857BBD for ; Fri, 15 Jul 2022 17:27:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EC403857BBD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 0D3631005DDDC for ; Fri, 15 Jul 2022 17:27:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CP6UoAO1kq24iCP6UoCYBY; Fri, 15 Jul 2022 17:27:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DaLSFthW c=1 sm=1 tr=0 ts=62d1a397 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=XhudognWbh8poeSwUtYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=51RK4h9hyaHmuEd+1r+c0+NFccBZfB//kARfq2BTuLs=; b=QhT8em0YJYZPJmJPl0tyduH/+Z QsD15/8JrzbTiFe+ij6UUV4QYUhpLMKpjyeE7gulQNqEwy+Q9iL79lO57BExKdhzdi8aMtB9+y73L zbL76sO+hZu0LNQe86BbNFU/Z; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56102 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCP6U-002iZm-BT; Fri, 15 Jul 2022 11:27:50 -0600 From: Tom Tromey To: Tiezhu Yang Cc: gdb-patches@sourceware.org Subject: Re: [COMMITTED PATCH] gdb: LoongArch: Implement the push_dummy_call gdbarch method References: <20220707091536.4884-1-yangtiezhu@loongson.cn> X-Attribution: Tom Date: Fri, 15 Jul 2022 11:27:46 -0600 In-Reply-To: <20220707091536.4884-1-yangtiezhu@loongson.cn> (Tiezhu Yang's message of "Thu, 7 Jul 2022 17:15:36 +0800") Message-ID: <875yjyp9pp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oCP6U-002iZm-BT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56102 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, PP_MIME_FAKE_ASCII_TEXT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 17:27:59 -0000 >>>>> Tiezhu Yang writes: > +static void > +pass_in_gar (struct regcache *regcache, unsigned int gar, const gdb_byte *val) In gdb, functions generally should have an introductory comment explaining their purpose. > +static __attribute__((aligned(16))) gdb_byte buf[1024] = { 0 }; > +static gdb_byte *addr = buf; I don't understand why a global is needed here, or why the attribute is needed. But anyway, the attribute isn't really portable, and since this is tdep code (not specific to some host where you could maybe get away with assuming the compiler), it can't be used. > +static unsigned int fixed_point_members = 0; > +static unsigned int floating_point_members = 0; > +static bool first_member_is_fixed_point = false; Please don't use globals for this kind of thing. You can make a new object or you can pass pointers to locals. > + /* integer or pointer type is passed in GAR. > + * If no GAR is available, it€s passed on the stack. > + * When passed in registers or on the stack, > + * the unsigned integer scalars are zero-extended to GRLEN bits, > + * and the signed integer scalars are sign-extended. */ In the gdb style, subsequent comment lines don't have the "*". thanks, Tom