From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id C8118388883D for ; Wed, 16 Mar 2022 16:40:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C8118388883D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 2925E100472A7 for ; Wed, 16 Mar 2022 16:40:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id UWhCnLxSYb2WGUWhCnfb59; Wed, 16 Mar 2022 16:40:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Cr16zl0D c=1 sm=1 tr=0 ts=623212f7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=4k9WKO3g7l1T9VMRm6UA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u8PqXPeGUY3B1vod7y/RM73OSZV5e4ygzEoXQBG/kUg=; b=qsq4Qmk2cEMPrwJ4L6f6CdZKyh QAhhZWZ9t8jS2UmSj+ZGT4LiB8ueXsRHO055kuFfIM/6yJM4f1poGXgjFItlkaQuzbO+V6SDI+f7l AeQAqU9Z921/T3LJYFFgHHGhv; Received: from 71-211-175-224.hlrn.qwest.net ([71.211.175.224]:37982 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUWhC-003e3m-9l; Wed, 16 Mar 2022 10:40:22 -0600 From: Tom Tromey To: Youling Tang Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: [PATCH] gdb: mips: Fix large-frame.exp test case failure References: <1647307310-21454-1-git-send-email-tangyouling@loongson.cn> X-Attribution: Tom Date: Wed, 16 Mar 2022 10:40:21 -0600 In-Reply-To: <1647307310-21454-1-git-send-email-tangyouling@loongson.cn> (Youling Tang's message of "Tue, 15 Mar 2022 09:21:50 +0800") Message-ID: <875yodkg0a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.175.224 X-Source-L: No X-Exim-ID: 1nUWhC-003e3m-9l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-175-224.hlrn.qwest.net (murgatroyd) [71.211.175.224]:37982 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 16:40:24 -0000 Hi. Thank you for the patch. >> The disassembly of the above func function shows that we may use instructions >> such as daddiu/daddu, so add "daddiu $gp,$gp,n", "daddu $gp,$gp,$t9" and >> "daddu $gp,$t9,$gp" to the mips32_scan_prologue function to fix the large-frame.exp >> test case. Since I don't know the MIPS architecture, my main question for this kind of patch is whether this applies to the whole MIPS family, or whether it somehow depends on some micro-architecture. If it applies universally, or if it can't hurt other forms of MIPS, then the patch itself looks good to me and you can go ahead. thanks, Tom