From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3F6783858D20 for ; Thu, 3 Mar 2022 16:49:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F6783858D20 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-IWg8SIf6Mfibf9JKfSO39g-1; Thu, 03 Mar 2022 11:49:26 -0500 X-MC-Unique: IWg8SIf6Mfibf9JKfSO39g-1 Received: by mail-wr1-f72.google.com with SMTP id b7-20020a05600003c700b001efac398af7so2256780wrg.22 for ; Thu, 03 Mar 2022 08:49:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=vsfVR1iiznHZ2SuPwbMEqcO8CbSbCPMP9kzBHqtUeEQ=; b=wfIM9aNUUZVvc50CvZ2w9kd9+91/LPrLUJHBxUuQhfykG5lhQbE1HdDhH+kgOIGJXr MQxany4eJStDBw9kMvli7LrKxh267d8sWupM15tqDltPyXiJwoOZVnIU91f+LngeYLeE 3RHQuX+I21VieYQXKnKb29mODd1zK92P3Rvos6aihYFzwh5yfzxiEC752rPtvOEt06M2 Hm1zzBzvaem+pJGB2JqE5ZTnTfrIasZTqgwUGyQi6LW2Gp5LSkb8NKMQG2MHQGI4Z3DC RDyCirjfuZ59H48+Dt28xIIWa9oBGwyOfyHz+tC9AWw3e6hitlHPk22Xf5gu8K/uixjq ExmA== X-Gm-Message-State: AOAM532ejWqJRR5IUZwi7ZgiBcYdpq0qWkCe1xKQV12Z2FZNC1t+mcef F6QWjhceo2fDorA74cLu7CxFLdx26JhviDz5Oxc5at26hkRuRr+2KT+b9YEtwwXwn0HN7L4spEq sdD5hRfyMTkJzRaXVVIdo4PqIvy+DZpAePotAy+x7WmShmjtoOJ7f7F2SVx245jkaS7BlIosynA == X-Received: by 2002:a05:600c:384a:b0:37c:2d14:a2d3 with SMTP id s10-20020a05600c384a00b0037c2d14a2d3mr4578155wmr.20.1646326165444; Thu, 03 Mar 2022 08:49:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMNvzrRkkjCYYH0cPcDieyFlyvTGmFUmMV4NBaEbnCSoqMLu9MghQeSyP32qj0gwHoxnrBsw== X-Received: by 2002:a05:600c:384a:b0:37c:2d14:a2d3 with SMTP id s10-20020a05600c384a00b0037c2d14a2d3mr4578142wmr.20.1646326165188; Thu, 03 Mar 2022 08:49:25 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id s17-20020adfbc11000000b001f023d197b8sm2484187wrg.68.2022.03.03.08.49.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 08:49:24 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: add gdb.Architecture.format_address In-Reply-To: <87ilt5br5i.fsf@redhat.com> References: <20220211161721.3252422-1-aburgess@redhat.com> <83leyhs07f.fsf@gnu.org> <878ru4cepy.fsf@redhat.com> <837d9oumhd.fsf@gnu.org> <87sfsbattq.fsf@redhat.com> <83ilt7t0s1.fsf@gnu.org> <87ilt5br5i.fsf@redhat.com> Date: Thu, 03 Mar 2022 16:49:23 +0000 Message-ID: <875yovx9po.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 16:49:30 -0000 Ping! Thanks, Andrew Andrew Burgess writes: > Eli Zaretskii via Gdb-patches writes: > >>> From: Andrew Burgess >>> Cc: gdb-patches@sourceware.org >>> Date: Tue, 22 Feb 2022 13:56:17 +0000 >>> >>> So, appologies, but this is another complete rewrite of the docs. With >>> the exception of the name, for which I still have no better suggestions, >>> how's this? >> >> Let's see... >> >>> +@defun Architecture.format_address (@var{address}) >>> +Return a string in the format @samp{@var{addr} >>> +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address} >>> +formatted in hexadecimal, @var{symbol} is the closest earlier symbol >>> +to @var{address}, and @var{offset} is the offset from @var{symbol} to >>> +@var{address} in decimal. >> >> I think instead of "closest earlier" it would be best to say >> >> ... @var{symbol} is the symbol whose address is the nearest to >> @var{address} and below it in memory ... >> >> Other than that, SGTM, thanks. > > Thanks for all your feedback. I've made this change locally, and it > will be included once someone has reviewed the rest of the code. > > Thanks, > Andrew