From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 01E17385842C for ; Mon, 21 Feb 2022 17:29:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01E17385842C Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-EqDBWBIFP4yoSpN3oG1nzQ-1; Mon, 21 Feb 2022 12:29:05 -0500 X-MC-Unique: EqDBWBIFP4yoSpN3oG1nzQ-1 Received: by mail-wr1-f69.google.com with SMTP id p18-20020adfba92000000b001e8f7697cc7so5675489wrg.20 for ; Mon, 21 Feb 2022 09:29:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=tmC7VuY2EJ9yoVifRua46ZNF6sAh7qEabPPTlrmYvFQ=; b=x2VX5ar/eTt/7h6ROG4sHBJs/3MOkkgmbVKGREpKdtu1a4ow2tmv74xzCZerfhZqqk w9uboLXYLQ/NWguak428SPmdMvEFkWh3BPDTI0o8l1F3EnolrlW+D+pm9YJMzEo04eug 120/+TuoDkDilCOOq6EUBch5PW09mTLuJ9KyRDIcOnBoZoZNndYF61kY7CISVrcF7C9/ 1mJKKzaQnZF53LqL9cnHHvrbmSMZifYjcS+d+e7XJPhOH4HpyRxxdQzlqXu+Dwnw+oAA MTM0jlsYk5L1AT6qbRiq8MNXva6s3ZowKJhXuOqMi+a72lhww0Gar7stGOsgdDm0xLk5 3pzg== X-Gm-Message-State: AOAM533gQjlPHOvDzhdETLrWNnxbPhXWUIajkGerbDNmDnBva829OVir dCFm2dKCI0iGiDx60PL5QV/i2H0h7X3//bzmAnPDYC9+/2ufFiJGtBSTA5hI11fpDrH4vyHPHF7 xoWiKUHlRCgs+lPotMiBii/NVjJvug1gPY1gHh7DVeg/pUNYOwv55qSJkAb8A2gKNYImLFEFoog == X-Received: by 2002:a1c:7918:0:b0:37b:fab4:9b1 with SMTP id l24-20020a1c7918000000b0037bfab409b1mr52269wme.40.1645464544035; Mon, 21 Feb 2022 09:29:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJx23SiTru3OEeykiCHxxokzkneBjDN+yjpuWg/TFWOW7JhQyaKe4hW8IF96qVNVosVFpYdIng== X-Received: by 2002:a1c:7918:0:b0:37b:fab4:9b1 with SMTP id l24-20020a1c7918000000b0037bfab409b1mr52254wme.40.1645464543752; Mon, 21 Feb 2022 09:29:03 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id u7sm42433644wrq.112.2022.02.21.09.29.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 09:29:03 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes In-Reply-To: References: Date: Mon, 21 Feb 2022 17:29:02 +0000 Message-ID: <875yp8cen5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 17:29:09 -0000 Ping! Thanks, Andrew Andrew Burgess writes: > I pushed the first two patches from the v1 series, but the rest of > that original series does need reviewing - those paches are included > in v2 as patches 1 to 5. > > The remaining 10 patches in the v2 series mostly relate to changing > how window resizing, and window layout occurs. > > The docs content in patches 1 and 5 of the v2 series is unchanged from > v1, and was already reviewed, so no new docs review is required there. > > There is some new docs content in patch 6, but its pretty minor; a > docs review is always welcome though. > > I'm hoping most of the changes in this series will be pretty > non-controversial, the only patch which I think might be more of a > personal taste issue is the very last one (left last for that reason). > I'd suggest selecting the split layout, and then playing with window > resizing to get a feel for the new behaviour. Feedback welcome. > > Thanks, > Andrew > > --- > > Andrew Burgess (15): > gdb: move some commands into the tui namespace > gdb/tui: rename tui_layout_base::adjust_size to ::set_height > gdb/tui: rename tui_layout_split:set_weights_from_heights > gdb/testing/tui: add new functionality to tuiterm.exp > gdb/tui: add new 'tui window width' command and 'winwidth' alias > gdb/tui: add a tui debugging flag > gdb/tui: add left_boxed_p and right_boxed_p member functions > gdb/tui/testsuite: refactor new-layout.exp test > gdb/tui: avoid fp exception when applying layouts > gdb/tui: fairer distribution of excess space during apply > gdb/tui: allow cmd window to change size in tui_layout_split::apply > gdb/tui: support placing the cmd window into a horizontal layout > gdb/testsuite: some additional tests in gdb.tui/scroll.exp > gdb/tui: relax restrictions on window max height and width > gdb/tui: fair split of delta after a resize > > gdb/NEWS | 25 ++ > gdb/doc/gdb.texinfo | 41 ++- > gdb/testsuite/gdb.tui/basic.exp | 4 +- > gdb/testsuite/gdb.tui/empty.exp | 14 +- > gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- > gdb/testsuite/gdb.tui/regs.exp | 4 +- > gdb/testsuite/gdb.tui/scroll.exp | 4 + > gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ > gdb/testsuite/gdb.tui/winwidth.exp | 63 ++++ > gdb/testsuite/lib/tuiterm.exp | 82 +++++- > gdb/tui/tui-command.c | 6 - > gdb/tui/tui-command.h | 2 - > gdb/tui/tui-layout.c | 419 +++++++++++++++++++++++---- > gdb/tui/tui-layout.h | 201 ++++++++++++- > gdb/tui/tui-win.c | 149 ++++++++-- > gdb/tui/tui.c | 26 ++ > gdb/tui/tui.h | 14 + > 17 files changed, 1089 insertions(+), 142 deletions(-) > create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp > > -- > 2.25.4