From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 5B1BB3858D39 for ; Tue, 18 Jan 2022 18:59:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B1BB3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id B72DC1004051B for ; Tue, 18 Jan 2022 18:59:36 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9thgn9kDLnAlU9thgn18dM; Tue, 18 Jan 2022 18:59:36 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=61e70e18 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=suIJnHHMcELyhERDAMgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=63hm9Au8iCgd6/RelhPJkRs1IwAAvp6/3Gd54l5IQZ4=; b=hUlflz6ZY2UJ1t+Zk37x7Jk8dv r6V5+hCQPvrOWFNaRCNCO+rvflEhkjFTB8E0UZXGHmHEklCn3khH3SqTKJwY+ZsLddAt0DbS0bBmf l8pOKhcCNkwNiD+0FmCPrwSDr; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55916 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9thf-000Ltf-Ex; Tue, 18 Jan 2022 11:59:35 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Simon Marchi , Andrew Burgess Subject: Re: [PATCH] gdb: unbuffer all input streams when not using readline References: <20220117164051.1854133-1-aburgess@redhat.com> <20220118170913.GH622389@redhat.com> <20220118180913.GI622389@redhat.com> X-Attribution: Tom Date: Tue, 18 Jan 2022 11:59:34 -0700 In-Reply-To: <20220118180913.GI622389@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 18 Jan 2022 18:09:13 +0000") Message-ID: <875yqgeup5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n9thf-000Ltf-Ex X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55916 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 18:59:38 -0000 Andrew> It does occur to me that some mi commands can produce a lot of Andrew> output. So, in the new-ui case, where we have a single FILE shared Andrew> for input and output, the unbuffering will impact output too, right, Andrew> so maybe that's where we'd see the slow down? That case could be Andrew> worked around by having new-ui open a new FILE for each stream. I think it's relatively simpler to add gdb-side buffering for output than for input. So if this is the issue, it seems not super hard to handle -- just write a buffering ui_file. Tom