From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id B7CBB3858403 for ; Fri, 14 Jan 2022 19:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7CBB3858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 2E4371003FEC9 for ; Fri, 14 Jan 2022 19:30:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 8SH7n7zuqXOyf8SH8n4err; Fri, 14 Jan 2022 19:30:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ot6Kdwzt c=1 sm=1 tr=0 ts=61e1cf46 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=hEMzvxVaEsqzYnOK4woA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4KFzhFCnIhIhqZD5Df9lA1JmXV4Uog1mf0H0o22Hoq0=; b=xhoVv+Xhu+QVPXuEMrvzDHckpj fPrkoTrS13Oo7Nv+G3yMl6XpclGnFfqSHWMnUMwp6KWgxymUX9F/hHRVShVhKapQDA6kUSIMJkulc Zel+veR+PAv15zKfw2lm59sl5; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55888 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n8SH6-003pSq-SL; Fri, 14 Jan 2022 12:30:12 -0700 From: Tom Tromey To: Christina Schimpe via Gdb-patches Subject: Re: [PATCH 1/3] gdb: Make global feature array a per-remote target array References: <20220113152118.1465255-1-christina.schimpe@intel.com> <20220113152118.1465255-2-christina.schimpe@intel.com> X-Attribution: Tom Date: Fri, 14 Jan 2022 12:30:12 -0700 In-Reply-To: <20220113152118.1465255-2-christina.schimpe@intel.com> (Christina Schimpe via Gdb-patches's message of "Thu, 13 Jan 2022 16:21:16 +0100") Message-ID: <875yqmglob.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n8SH6-003pSq-SL X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55888 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 19:30:16 -0000 >>>>> ">" == Christina Schimpe via Gdb-patches writes: >> This patch applies the appropriate FIXME notes described in commit >> 5b6d1e4 "Multi-target support". Thank you for the patch. I have a couple of small things, but nothing too serious. On the whole, this approach makes sense to me. >> + int remote_multi_process_p (remote_state *rs) const; >> + int remote_fork_event_p (remote_state*) const; >> + int remote_vfork_event_p (remote_state*) const; >> + int remote_exec_event_p (remote_state*) const; It seems like these methods don't actually need the 'remote_state *' parameter. >> + void reset_all_packet_configs_support (void); New code shouldn't use "(void)", just "()" is fine. Also, normally if we touch a function definition or declaration, we'll also remove a 'void' if there is one. >> +static void >> +set_remote_protocol_packet_cmd (const char *args, int from_tty, >> + cmd_list_element *c) >> + for (int i = 0; i < PACKET_MAX; ++i) >> + { >> + if (c == remote_protocol_packets[i].set_cmd) >> + { The packet number can be passed in using the 'context' attached to the command. See cmd_list_element::set_context and cmd_list_element::context. This is simple to do and would remove the need for this loop. It's mildly annoying that this only accepts a pointer and not a scalar, but it can either be cast or you could pass the address the slot in remote_protocol_packets and then do some pointer math to reconstruct the index. The same applies to the 'show' command. thanks, Tom