From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.252]) by sourceware.org (Postfix) with ESMTPS id 8D6A23857036 for ; Mon, 6 Sep 2021 19:46:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D6A23857036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 01C24281F for ; Mon, 6 Sep 2021 14:46:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NKZKmZqVCjSwzNKZKmzAE8; Mon, 06 Sep 2021 14:46:14 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ovp3jrAPwUJE8kmpU5RtaaV2nZ7S2odujBPQ+HKUMnM=; b=rWGmz7f9GssgW4bZizYRpAFyUs DGSGHYSl73EJfQyq4LG3fPpBR7NMqqy+bzlmA5eVxunQwEWf+lvWuqW15tgdxM4JXh+e2uAoiUkHH HswBrgJmb6sZ0SrhAc6MUQ3Tu; Received: from 97-122-72-212.hlrn.qwest.net ([97.122.72.212]:60450 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mNKZK-002lk9-Mq; Mon, 06 Sep 2021 13:46:14 -0600 From: Tom Tromey To: Tom Tromey Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 00/30] Rewrite the DWARF "partial" reader References: <20210826021937.1490292-1-tom@tromey.com> <554345a9-ad2c-845e-9179-320a6967b07d@suse.de> <87lf4nlws2.fsf@tromey.com> <87r1ebj7nt.fsf@tromey.com> X-Attribution: Tom Date: Mon, 06 Sep 2021 13:46:13 -0600 In-Reply-To: <87r1ebj7nt.fsf@tromey.com> (Tom Tromey's message of "Mon, 30 Aug 2021 09:04:22 -0600") Message-ID: <875yvdjxmi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.72.212 X-Source-L: No X-Exim-ID: 1mNKZK-002lk9-Mq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-72-212.hlrn.qwest.net (localhost.localdomain) [97.122.72.212]:60450 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2021 19:46:18 -0000 Tom> $ total=100; worker_threads=unlimited; pass=0; for n in $(seq 1 $total); Tom> do gdb -q -batch -iex "maint set worker-threads $worker_threads" Tom> ./outputs/gdb.cp/cpexprs-debug-types/cpexprs-debug-types >LOG 2>ERR; if Tom> [ $? -eq 0 ]; then pass=$(($pass + 1)); fi; done; echo "PASS: $pass/$total" Tom> PASS: 62/100 Me> Thanks. I was able to reproduce it this way. I'm looking into it. This one turned out to be a data race due to how type units are handled. However, the racy parts are actually unused, and I think can just be deleted. The next version of the series will do that, combining a couple of patches at the end to make it a bit simpler. Tom> Dwarf Error: DW_FORM_strp used without required section^M Tom> Dwarf Error: DW_FORM_strp used without required section^M Me> In this case I think one idea is to de-duplicate the errors before Me> printing them. I am going to implement this soon. I also realized that 'complaint' is not thread-safe, but can be run in the worker threads. I have a patch for this now as well. I hope to send an updated series soon, but I'm not sure exactly when yet. Tom