From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Document quick_symbol_functions::expand_symtabs_matching invariant
Date: Fri, 16 Jul 2021 13:54:14 -0600 [thread overview]
Message-ID: <875yxahw61.fsf@tromey.com> (raw)
In-Reply-To: <20210627142430.993717-1-tom@tromey.com> (Tom Tromey's message of "Sun, 27 Jun 2021 08:24:30 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> While working on my series to replace the DWARF psymbol reader, I
Tom> noticed that the expand_symtabs_matching has an undocumented
Tom> invariant. I think that, if this invariant is not followed, then GDB
Tom> will crash. So, this patch documents this in the relevant spots and
Tom> introduces some asserts to make it clear.
Tom> Regression tested on x86-64 Fedora 32.
I'm checking this in.
Tom
prev parent reply other threads:[~2021-07-16 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 14:24 Tom Tromey
2021-07-16 19:54 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yxahw61.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).