From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.78]) by sourceware.org (Postfix) with ESMTPS id 84FAA39890B5 for ; Fri, 16 Jul 2021 19:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 84FAA39890B5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 2E1186B071 for ; Fri, 16 Jul 2021 14:56:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4TuZm1hQKuMjb4TuZmnTrG; Fri, 16 Jul 2021 14:54:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hwgmEHDRwjCqCofWcQS1/DdYMGokFFMvo+1nUMGtxj0=; b=AG7INKDj3gBgV0axEbsQyAxIyx QhDn7wepqzOl9kiJqcKZSCJgpX/apAFj73iNQlHlrwdZFNttEVIh9jhCMeQlg2zKy3Fg6xzYvrVLW R5kQryDI/qA2lbEffP0VscdQq; Received: from 71-211-145-10.hlrn.qwest.net ([71.211.145.10]:45572 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m4TuY-001eXE-Of; Fri, 16 Jul 2021 13:54:14 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Document quick_symbol_functions::expand_symtabs_matching invariant References: <20210627142430.993717-1-tom@tromey.com> X-Attribution: Tom Date: Fri, 16 Jul 2021 13:54:14 -0600 In-Reply-To: <20210627142430.993717-1-tom@tromey.com> (Tom Tromey's message of "Sun, 27 Jun 2021 08:24:30 -0600") Message-ID: <875yxahw61.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.145.10 X-Source-L: No X-Exim-ID: 1m4TuY-001eXE-Of X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-145-10.hlrn.qwest.net (murgatroyd) [71.211.145.10]:45572 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 19:56:22 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> While working on my series to replace the DWARF psymbol reader, I Tom> noticed that the expand_symtabs_matching has an undocumented Tom> invariant. I think that, if this invariant is not followed, then GDB Tom> will crash. So, this patch documents this in the relevant spots and Tom> introduces some asserts to make it clear. Tom> Regression tested on x86-64 Fedora 32. I'm checking this in. Tom