From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.179.30]) by sourceware.org (Postfix) with ESMTPS id 272953858024 for ; Thu, 1 Apr 2021 17:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 272953858024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C4FC36DC3 for ; Thu, 1 Apr 2021 12:52:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S1UQlLcoLb8LyS1UQlcIsX; Thu, 01 Apr 2021 12:52:18 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+E72XiyU+9fi7IagQ+H4QJVCNoI1JOxgPiWHAkAEKsI=; b=BGjrlpxgcb/IaxVttXbo4tUaFO p0JEGwwUS4cqLfJqM5SeSS09JZBaKfdzI/ETFvgtZWxKUu9CBl5MEy4grMvRCHojX8ouiMbzarpVW 2V1OwQAD+4M2T2MOETAfao3Wd; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:44548 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lS1UQ-001Dyz-Gf; Thu, 01 Apr 2021 11:52:18 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 4/4] gdb: remove objfile parameter from get_objfile_bfd_data References: <20210322193417.2376788-1-simon.marchi@efficios.com> <20210322193417.2376788-5-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 01 Apr 2021 11:52:17 -0600 In-Reply-To: <20210322193417.2376788-5-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 22 Mar 2021 15:34:17 -0400") Message-ID: <875z15q4dq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lS1UQ-001Dyz-Gf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:44548 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 17:52:20 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> But if the BFD requires relocation, get_objfile_bfd_data returns a newly Simon> allocated object that isn't kept anywhere else (and isn't shared). So Simon> the objfile becomes the owner of the objfile_per_bfd_storage object. In Simon> objfile::~objfile, we have this: Simon> if (obfd) Simon> gdb_bfd_unref (obfd); Simon> else Simon> delete per_bfd; Simon> I'm thinking that obfd could be non-nullptr, and it could require Simon> relocation. In that case, it would never be freed. Anyway, that's not Simon> really connected to this patch. Yes, this seems like a bug. Probably objfile should just have an explicit "owns_per_bfd" boolean somewhere. Simon> gdb/ChangeLog: Simon> * objfiles.c (get_objfile_bfd_data): Remove objfile parameter, Simon> adjust callers. This looks good to me. Thank you. Tom