From: Tom Tromey <tom@tromey.com>
To: Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH,V3 2/3] CTF: handle forward reference type
Date: Thu, 01 Apr 2021 10:56:34 -0600 [thread overview]
Message-ID: <875z16q6yl.fsf@tromey.com> (raw)
In-Reply-To: <1617237594-24175-3-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Wed, 31 Mar 2021 20:39:53 -0400")
>> Added function fetch_tid_type which calls get_tid_type and will set up
>> the type, associated with a tid, if it is not read in yet. Also implement
>> function read_forward_type which handles the CTF_K_FORWARD kind.
>> Expanded gdb.base/ctf-ptype.exp to add cases with forward references.
Thanks for the patch.
>> + if (name != NULL && strlen (name.get() ) != 0)
A nit here -- "get() )" should be "get ())"
This is ok with this change.
Tom
next prev parent reply other threads:[~2021-04-01 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 0:39 [PING][PATCH,V3 0/3] CTF: bug fixes and new features Weimin Pan
2021-04-01 0:39 ` [PATCH,V3 1/3] CTF: fix incorrect function return type Weimin Pan
2021-04-01 0:39 ` [PATCH,V3 2/3] CTF: handle forward reference type Weimin Pan
2021-04-01 0:39 ` [PATCH,V3 3/3] CTF: multi-CU and archive support Weimin Pan
2021-04-01 17:30 ` Tom Tromey
2021-04-01 16:56 ` Tom Tromey [this message]
2021-04-08 1:09 ` [PATCH,V3 2/3] CTF: handle forward reference type Weimin Pan
2021-04-01 16:54 ` [PATCH,V3 1/3] CTF: fix incorrect function return type Tom Tromey
2021-04-01 19:00 ` Wei-min Pan
-- strict thread matches above, loose matches on Subject: below --
2021-03-20 0:44 [PATCH,V3 0/3] CTF: bug fixes and new features Weimin Pan
2021-03-20 0:44 ` [PATCH,V3 1/3] CTF: fix incorrect function return type Weimin Pan
2021-03-20 0:44 ` [PATCH,V3 2/3] CTF: handle forward reference type Weimin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z16q6yl.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).