Re: [PATCH] gdb: use make_scoped_restore to restore gdbpy_current_objfile

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The current mechanism by which the Python gdb.current_objfile is
Andrew> maintained does not allow for nested auto-load events.  It is assumed
Andrew> that one an auto-load script has finished loading then the current
Andrew> objfile should be set back to NULL.  In a nested situation, we should
Andrew> be restoring the previous value.

Andrew> We already have an RAII class to handle save/restore type behaviour,
Andrew> so lets just switch to use that.

Andrew> The test is a little contrived, but is simple enough, and triggers the
Andrew> bug.  The real use case might involve the auto-load script calling
Andrew> functions (either in the just-loaded object file, or in the main
Andrew> executable), which in turn trigger further auto-loads to occur.

That test sure looks like a lot of work :-)

Andrew> 	* python/python.c (gdbpy_source_objfile_script): Use
Andrew> 	make_scoped_restore to restore gdbpy_current_objfile.
Andrew> 	(gdbpy_execute_objfile_script): Likewise.

This looks good to me.

Tom