From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.59.4]) by sourceware.org (Postfix) with ESMTPS id 34EBB3858D38 for ; Sun, 5 Jul 2020 15:59:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 34EBB3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 5ABF0400D0D8B for ; Sun, 5 Jul 2020 09:38:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id s72jjeAIOXGIks72jjvnX4; Sun, 05 Jul 2020 10:59:03 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sErUnruInlyIzDLZqJWqFs1eiF1p+LKc5mdcWodtFcw=; b=lreoe7aPcxGOgJjWFBE5Lp4lQ4 4q8Ubq2M/ERIFtwodRl5zL3/Lu/4eDVyPSBkPfyEevZLz81gAayB6GHQKTAlx8lejoLGvYBfWdL8/ E1i7zqwoIj0adiSURCDkBh/uO; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:45550 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1js72j-001ryE-2U; Sun, 05 Jul 2020 09:59:01 -0600 From: Tom Tromey To: Christian Biesinger via Gdb-patches Cc: Tom Tromey , Christian Biesinger Subject: Re: [PATCH v2 2/7] Add "help news" References: <20200623132006.15863-1-tom@tromey.com> <20200623132006.15863-3-tom@tromey.com> X-Attribution: Tom Date: Sun, 05 Jul 2020 09:59:00 -0600 In-Reply-To: (Christian Biesinger via Gdb-patches's message of "Tue, 23 Jun 2020 13:18:14 -0500") Message-ID: <875zb2kl6j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1js72j-001ryE-2U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (bapiya) [174.16.104.48]:45550 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2020 15:59:06 -0000 >>>>> "Christian" == Christian Biesinger via Gdb-patches writes: Christian> On Tue, Jun 23, 2020 at 8:20 AM Tom Tromey wrote: >> +static void >> +help_news (struct ui_file *stream) >> +{ >> + std::string news_name = std::string (gdb_datadir) + SLASH_STRING + "NEWS"; >> + gdb_file_up news_file = gdb_fopen_cloexec (news_name.c_str (), "r"); >> + if (news_file == nullptr) >> + perror_with_name (_("could not open the NEWS file")); >> + >> + char buffer[1024]; >> + size_t offset = 0; >> + while (true) >> + { >> + size_t nbytes = fread (&buffer[offset], 1, sizeof (buffer) - offset, >> + news_file.get ()); Christian> Why not use read_entire_file from your other patch? The NEWS file seems large-ish, and I figured the normal thing for users would be to use the pager to view the top, then stop reading. Tom