From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.133]) by sourceware.org (Postfix) with ESMTPS id DC289385BF92 for ; Wed, 1 Apr 2020 20:03:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC289385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 7F685400D143B for ; Wed, 1 Apr 2020 15:03:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JjaYjvr0ySl8qJjaYjRcb8; Wed, 01 Apr 2020 15:03:50 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ASdMcvUI/Ql1CYx2SXf1BleYN0uU0g0Wht2wtLZMYVk=; b=Ta6KRyi+PNVD7XIR2VnG0iAguB GZ6sC7gQ6R+Fvb1Hf6QKraZI2P/hv1NY/fG5oCSNKKwmwwy/jplJxbqQd2ioS8oy+k8hvCnFdEyNe upo526Vukb6kg5G0qfTzfKrTk; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:33530 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJjaY-0028SF-8o; Wed, 01 Apr 2020 14:03:50 -0600 From: Tom Tromey To: Christian Biesinger via Gdb-patches Cc: Christian Biesinger , Eli Zaretskii Subject: Re: [PATCH] Clarify when dont_repeat should be called References: <20200312204419.188271-1-cbiesinger@google.com> X-Attribution: Tom Date: Wed, 01 Apr 2020 14:03:49 -0600 In-Reply-To: <20200312204419.188271-1-cbiesinger@google.com> (Christian Biesinger via Gdb-patches's message of "Thu, 12 Mar 2020 15:44:19 -0500") Message-ID: <875zej0y8q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJjaY-0028SF-8o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:33530 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 20:03:52 -0000 >>>>> "Christian" == Christian Biesinger via Gdb-patches writes: Christian> It is not immediately obvious that Command.dont_repeat should be called Christian> in invoke(), not in __init__. Make this obvious in the documentation. I didn't see a review of this. Probably Eli just missed it; CC'ing him. I think it's worth having. Tom