From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64122 invoked by alias); 18 Feb 2020 20:42:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64087 invoked by uid 89); 18 Feb 2020 20:42:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 20:41:58 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 79FB6122DB for ; Tue, 18 Feb 2020 14:41:57 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 49grjFSMIvBMd49grjCsk5; Tue, 18 Feb 2020 14:41:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jdQqDR92kAloCnS12A61IvAw8DOZniyJhps/GyPh/eI=; b=Zvt1qlaY7ht9QAx5oTGE2SyVct aTtsihHXH0Nu8kekSc9oeJsxMLgF6WAOHHpxR2jVx8YyLwYcvMr/+hykOZq30tkwrwKID9C8CzM3U Ig9yYj7Y53tr9jd4hFAKkON3S; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:49084 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j49gr-001kM9-8C; Tue, 18 Feb 2020 13:41:57 -0700 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb: allow duplicate enumerators in flag enums References: <20200213203035.30157-1-simon.marchi@efficios.com> <20200213203035.30157-3-simon.marchi@efficios.com> <87a75f7hs7.fsf@tromey.com> Date: Tue, 18 Feb 2020 20:42:00 -0000 In-Reply-To: <87a75f7hs7.fsf@tromey.com> (Tom Tromey's message of "Tue, 18 Feb 2020 13:38:16 -0700") Message-ID: <875zg37hm3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00738.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Maybe instead it should check for duplicate enumerator values and allow Tom> those, while still disallowing enums with conflicts, like: Tom> enum x { Tom> one = 0x11, Tom> two = 0x10, Tom> three = 0x01 Tom> }; Tom> ... which probably isn't a sensible flag enum. You can ignore this, I see it was already mentioned in patch 2. Tom