public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	 Tom Tromey <tom@tromey.com>,
	 gdb-patches@sourceware.org
Subject: Re: [RFC][gdb/testsuite] Ignore pass in gdb_caching_proc
Date: Tue, 18 Feb 2020 15:29:00 -0000	[thread overview]
Message-ID: <875zg3ewxn.fsf@tromey.com> (raw)
In-Reply-To: <d7571323-6462-5eff-0dd8-99f51415410e@suse.de> (Tom de Vries's	message of "Tue, 18 Feb 2020 11:59:26 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +proc ignore_pass { msg } {
Tom> +    verbose -log "gdb_do_cache_wrap ignoring pass: $msg"
Tom> +}
Tom> +
Tom> +proc gdb_do_cache_wrap {real_name} {
Tom> +    if { [info procs save_pass] != "" } {

I think the new procs should have introductory comments, but other than
that, this seems fine to me.

Tom

  reply	other threads:[~2020-02-18 15:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 10:58 [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp Tom de Vries
2020-02-13 14:32 ` Tom Tromey
2020-02-13 15:02   ` Tom de Vries
2020-02-17 20:52     ` Simon Marchi
2020-02-17 23:23       ` Tom de Vries
2020-02-17 23:58         ` Simon Marchi
2020-02-18  9:39           ` [committed][gdb/testsuite] Handle missing gnatmake in gnat_runtime_has_debug_info Tom de Vries
2020-02-18 10:59             ` [RFC][gdb/testsuite] Ignore pass in gdb_caching_proc Tom de Vries
2020-02-18 15:29               ` Tom Tromey [this message]
2020-02-19  6:07                 ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zg3ewxn.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).