From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91091 invoked by alias); 23 Jan 2020 22:03:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90767 invoked by uid 89); 23 Jan 2020 22:03:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:CAPTJ0X, H*f:sk:f4b3914, H*f:sk:EsCnHjJ, H*f:sk:83d0bi3 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 22:03:11 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 4F94F400C788F for ; Thu, 23 Jan 2020 16:03:10 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ukZCivbNa5mEZukZCiIrCW; Thu, 23 Jan 2020 16:03:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VURjgiz0MbwuMjeNe8H5r46+gmzQ9aHhkuPUGo1YqMw=; b=q6M/jCzqlGTfao6krOyNOCbnfq e6r6UxdOEVYoW/jW2gxiuMMKNTebfgL5F5Hovlgswp+k6E6+y8Wctvf8QT1fUBBdWbsJcdz+EYoHE w7T1prZoZIF7zDjb1jS40tiUx; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:57062 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iukZC-0014uX-1T; Thu, 23 Jan 2020 15:03:10 -0700 From: Tom Tromey To: Pedro Alves Cc: Eli Zaretskii , Tom Tromey , cbiesinger@google.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> <83d0bi348d.fsf@gnu.org> <871rrygco6.fsf@tromey.com> <874kwteraa.fsf@tromey.com> <83v9p919hy.fsf@gnu.org> Date: Thu, 23 Jan 2020 22:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 20 Jan 2020 15:48:22 +0000") Message-ID: <875zh1suea.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00762.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I'm not sure about that solution -- won't --avoid=stat mean that Pedro> we disable any stat gnulib fix for all platforms, instead of just Pedro> for Windows? Yeah. Actually, there is one more option for us, which is to patch gnulib in-tree. We already have the machinery to do this. Pedro> So I think we can take advantage of that to be able to make sure that Pedro> when we include "bfd.h", its functions are declared using the system's Pedro> stat, which is the same version that bfd is built against. Pedro> See prototype patch below, particularly common-types.h, which the Pedro> place where we include bfd.h for the first time. Pedro> It builds with my mingw cross compiler, the remaining issue would be Pedro> looking more in detail to the to_sys_stat conversion function. This looks reasonably promising to me. Tom