public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Introduce dwarf2_cu::get_builder
Date: Fri, 30 Nov 2018 20:32:00 -0000	[thread overview]
Message-ID: <875zwemhlr.fsf@tromey.com> (raw)
In-Reply-To: <20181126230855.27040-1-keiths@redhat.com> (Keith Seitz's message	of "Mon, 26 Nov 2018 15:08:55 -0800")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

I just noticed this version...

Keith> +private:
Keith>    /* The symtab builder for this CU.  This is only non-NULL when full
Keith>       symbols are being read.  */
Keith> -  std::unique_ptr<buildsym_compunit> builder;
Keith> +  std::unique_ptr<buildsym_compunit> m_builder;

Good idea, thanks for doing this.

I think the previous nits still apply; though this email didn't include
the test so I don't know for certain about those.

thanks,
Tom

      reply	other threads:[~2018-11-30 20:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 23:09 Keith Seitz
2018-11-30 20:32 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zwemhlr.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).