From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127250 invoked by alias); 30 Nov 2018 20:32:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126462 invoked by uid 89); 30 Nov 2018 20:32:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 20:32:35 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 078664DFE5 for ; Fri, 30 Nov 2018 14:32:34 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SpSkgsvkgkBj6SpSkgomyi; Fri, 30 Nov 2018 14:32:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3MpJD4Q9BitbcjZnKkhGI64EV76anr6vDpQFe1rCfqk=; b=mCxFgrkzfh0eWhGEE3VnimpNf+ n8MBCCj8l1kV1cnl7Nz/TfwjHe7O+CKjyfFRxIGSeWgw4+9WB/E4zOiaA6uotT7QHGM+zKclgGpQM +MjjUxpUxuLuavZ3PPZ9mgw82; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:58596 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSpSj-002BKP-PK; Fri, 30 Nov 2018 14:32:33 -0600 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Introduce dwarf2_cu::get_builder References: <20181126230855.27040-1-keiths@redhat.com> Date: Fri, 30 Nov 2018 20:32:00 -0000 In-Reply-To: <20181126230855.27040-1-keiths@redhat.com> (Keith Seitz's message of "Mon, 26 Nov 2018 15:08:55 -0800") Message-ID: <875zwemhlr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00587.txt.bz2 >>>>> "Keith" == Keith Seitz writes: I just noticed this version... Keith> +private: Keith> /* The symtab builder for this CU. This is only non-NULL when full Keith> symbols are being read. */ Keith> - std::unique_ptr builder; Keith> + std::unique_ptr m_builder; Good idea, thanks for doing this. I think the previous nits still apply; though this email didn't include the test so I don't know for certain about those. thanks, Tom