From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
Date: Wed, 31 Oct 2018 15:03:00 -0000 [thread overview]
Message-ID: <875zxinoo9.fsf@tromey.com> (raw)
In-Reply-To: <f062185a-be33-7966-eced-5e547c373966@ericsson.com> (Simon Marchi's message of "Tue, 30 Oct 2018 21:03:42 +0000")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>> It would be normal to look at TMPDIR on unix systems.
Simon> Ah, indeed. How is it with this little fixup on top of the patch?
Seems reasonable, thanks!
Simon> + char *tmp = getenv ("TMPDIR");
A tiny nit: you can use const char * here.
Tom
next prev parent reply other threads:[~2018-10-31 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 22:31 [PATCH v2 0/6] A different approach to startup-with-shell on macOS Tom Tromey
2018-10-18 22:31 ` [PATCH v2 2/6] Move make_temp_filename to common/pathstuff.c Tom Tromey
2018-10-18 22:31 ` [PATCH v2 5/6] Do not reopen temporary files Tom Tromey
2018-10-18 22:31 ` [PATCH v2 4/6] Use mkostemp, not mkstemp Tom Tromey
2018-10-18 22:31 ` [PATCH v2 6/6] Cache a copy of the user's shell on macOS Tom Tromey
2018-10-20 2:35 ` Simon Marchi
2018-10-27 17:43 ` Tom Tromey
2018-10-18 22:31 ` [PATCH v2 1/6] Unify shell-finding logic Tom Tromey
2018-10-19 23:27 ` Sergio Durigan Junior
2018-10-27 17:41 ` Tom Tromey
2018-10-18 22:31 ` [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c Tom Tromey
2018-10-29 16:01 ` Simon Marchi
2018-10-29 22:16 ` Simon Marchi
2018-10-30 20:55 ` Tom Tromey
2018-10-30 21:04 ` Simon Marchi
2018-10-31 15:03 ` Tom Tromey [this message]
2018-11-01 19:44 ` Simon Marchi
2018-10-19 23:41 ` [PATCH v2 0/6] A different approach to startup-with-shell on macOS Sergio Durigan Junior
2018-10-27 17:58 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2018-10-03 21:02 [PATCH 2 0/6] A different approach to starutp-with-shell " Tom Tromey
2018-10-03 21:02 ` [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zxinoo9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).