From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20503 invoked by alias); 24 Sep 2018 15:25:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20332 invoked by uid 89); 24 Sep 2018 15:24:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=hurry X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 15:24:57 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 983E53082134; Mon, 24 Sep 2018 15:24:55 +0000 (UTC) Received: from localhost (ovpn-124-61.rdu2.redhat.com [10.10.124.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FF571084383; Mon, 24 Sep 2018 15:24:28 +0000 (UTC) From: Sergio Durigan Junior To: Rainer Orth Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide Solaris 11 buildbots References: <874lelw9r3.fsf@redhat.com> <877ejguuo0.fsf@redhat.com> <87fty4teps.fsf@redhat.com> <871s9ote89.fsf@redhat.com> Date: Mon, 24 Sep 2018 15:25:00 -0000 In-Reply-To: (Rainer Orth's message of "Mon, 24 Sep 2018 16:36:01 +0200") Message-ID: <875zyuq5pr.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00808.txt.bz2 On Monday, September 24 2018, Rainer Orth wrote: > Hi Sergio, > >>>>> So, there were a few problems in the master.cfg file which prevented the >>>>> builders to actually build GDB. I fixed them, and they're now >>>>> processing the queue. However, the builds are failing. For example: >>>>> >>>>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/3/steps/compile%20gdb/logs/stdio >>>>> >>>>> This seems to be the problem you were talking about, regarding >>>>> unittests/string_view-selftests.o. You mentioned that this breakage >>>>> shouldn't happen if we don't use -D_GLIBCXX_DEBUG, right? Can you >>>>> please take a look at this? >>>> >>>> until your --enable-unit-tests patch is in (when we can keep the default >>>> options and just add --disable-unit-tests to the configure line), we'd >>>> need to build with CFLAGS/CXXFLAGS=-g -O -D_GLIBCXX_DEBUG until PR >>>> build/23676 is resolved. That's what worked for me locally. >>> >>> Ah, I thought that if we didn't use "-g -D_GLIBCXX_DEBUG", then the >>> build would be OK. >> >> That's what I tried first when I encountered the problem here. However, >> even the minimal testcase in the PR fails with just -g alone. >> >> Could you please try if the following patch allows the build to succeed? > > it seems we managed to mess up the configure flags badly here: right now > the buildbots are configured with just CFLAGS/CXXFLAGS=-m64, nothing > more. I hope the following patch should fix things: Ah, OK. I may have misunderstood the patch/requirements. I've now simplified the configuration. > * There's no need for disable_default_compilation_flags = True: the > default works just fine, we only need to add -O at the moment. Isn't > it enough to do this once in RunTestGDBSolaris_Common? Yeah, it should be. > * Obviously the -m64 needs to be appended in RunTestGDBPlainSolaris_c64 > to both CFLAGS and CXXFLAGS to avoid losing the -O above. Yeah. > * Not in the patch, but wouldn't it be enough to set enable_targets_all, > make_command, and run_testsuite only once in RunTestGDBSolaris_Common? It turned out to be a bit more complicated. I'm in a hurry right now, so I did a quick hack to make it work. I'll monitor the next builds. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/