public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: John Darrington <john@darrington.wattle.id.au>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow remote debugging over a local domain socket
Date: Fri, 31 Aug 2018 15:10:00 -0000	[thread overview]
Message-ID: <875zzq1skc.fsf@tromey.com> (raw)
In-Reply-To: <20180831101818.9175-1-john@darrington.wattle.id.au> (John	Darrington's message of "Fri, 31 Aug 2018 12:18:18 +0200")

>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:

John> Extend the "target remote"  and "target extended-remote" commands
John> such that if the filename provided is a unix domain (AF_UNIX)
John> socket, then it'll be treated as such, instead of trying to open
John> it as if it were a character device.

Thanks for the patch.
This looks essentially reasonable to me.

John> +/* Open a AF_UNIX socket.  */
John> +int
John> +socket_open (struct serial *scb, const char *name)
John> +{

It seems to me that all the functions in this file could be static.
This might necessitate wrapping many of them in "#ifndef USE_WIN32API"
to avoid warnings about unused code, but that seems like an improvement
as well.

John> +int
John> +ser_socket_send_break (struct serial *scb)
John> +{
John> +  /* Send telnet IAC and BREAK characters.  */
John> +  return (serial_write (scb, "\377\363", 2));
John> +}

I don't really know what's expected here, but is this correct?

John> diff --git a/gdb/ser-socket.h b/gdb/ser-socket.h
John> new file mode 100644
John> index 0000000000..58509302d6
John> --- /dev/null
John> +++ b/gdb/ser-socket.h

You could just drop this file entirely.

Tom

  parent reply	other threads:[~2018-08-31 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  7:05 Remote debugging over local domain sockets? John Darrington
2018-08-29 15:17 ` Tom Tromey
2018-08-29 15:28   ` John Darrington
2018-08-29 15:39     ` Tom Tromey
2018-08-31 10:18       ` [PATCH] Allow remote debugging over a local domain socket John Darrington
2018-08-31 14:59         ` Eli Zaretskii
2018-08-31 15:10           ` John Darrington
2018-08-31 17:50             ` Eli Zaretskii
2018-08-31 15:10         ` Tom Tromey [this message]
2018-08-31 15:12           ` John Darrington
2018-08-31 16:01         ` Pedro Alves
2018-08-31 16:40           ` John Darrington
2018-09-03 13:19             ` Pedro Alves
2018-09-03 18:49               ` John Darrington
2018-10-01 19:45                 ` Pedro Alves
2018-10-02 10:16                   ` John Darrington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zzq1skc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=john@darrington.wattle.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).