From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2] gdb: Don't call gdb_load_shlib unless GDB is running
Date: Fri, 27 Jul 2018 15:10:00 -0000 [thread overview]
Message-ID: <8760107m0j.fsf@tromey.com> (raw)
In-Reply-To: <20180717172843.5967-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 17 Jul 2018 18:28:43 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> This commit also adds a check to gdb_load_shlib that GDB is running.
Andrew> The check is always performed, so this should catch cases where a GDB
Andrew> developer adds a use of gdb_load_shlib but doesn't test their code
Andrew> with a remote target.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.trace/tspeed.exp: Only call gdb_load_shlib after gdb has
Andrew> started.
Andrew> * lib/gdb.exp (gdb_load_shlib): Call perror if GDB is not running.
Thank you. This patch is OK.
Tom
prev parent reply other threads:[~2018-07-27 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 17:06 [PATCH] " Andrew Burgess
2018-07-12 16:11 ` Keith Seitz
2018-07-17 17:28 ` [PATCHv2] " Andrew Burgess
2018-07-27 15:10 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760107m0j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).