From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40731 invoked by alias); 21 Jun 2018 18:27:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40307 invoked by uid 89); 21 Jun 2018 18:27:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:958, his X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.228) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 18:27:00 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 53EC736B04 for ; Thu, 21 Jun 2018 13:26:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id W4I8fxmJ879N3W4IGfP5bA; Thu, 21 Jun 2018 13:26:58 -0500 X-Authority-Reason: nr=8 Received: from 75-166-79-120.hlrn.qwest.net ([75.166.79.120]:40010 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fW4I8-001VnR-F4; Thu, 21 Jun 2018 13:26:44 -0500 From: Tom Tromey To: Simon Marchi Cc: Omair Javaid , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] [PR gdb/21695] Fix lost line info for symbol at addr zero References: <1526393061-18039-1-git-send-email-omair.javaid@linaro.org> Date: Thu, 21 Jun 2018 18:27:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 20 Jun 2018 12:12:40 -0400") Message-ID: <87602cov18.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fW4I8-001VnR-F4 X-Source-Sender: 75-166-79-120.hlrn.qwest.net (pokyo) [75.166.79.120]:40010 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00527.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I have added Tom Tromey in CC, he is currently playing with storing Simon> symbols relocated vs unrelocated, so maybe he knows better. And maybe Simon> there's something in his pending patches that also touch this area. The patch seems reasonable to me. I think it may touch the same code as my line table series, but that's no big deal. I'll rebase when the time comes. >> + CORE_ADDR lowpc_minus_base, CORE_ADDR address) Simon> I would suggest naming this "unrelocated_lowpc". Can you update the Simon> documentation of the method to describe that parameter? Agreed. >> /* If address < lowpc then it's not a usable value, it's outside the >> pc range of the CU. However, we restrict the test to only This comment could also use an update, and it should be using upper-case like "ADDRESS" and "LOWPC". Tom