From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [CANCEL] [PATCH 0/3] Convert probe interfaces to C++ (and perform some cleanups)
Date: Mon, 13 Nov 2017 17:58:00 -0000 [thread overview]
Message-ID: <8760aeoybv.fsf@redhat.com> (raw)
In-Reply-To: <20171113175319.24280-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Mon, 13 Nov 2017 12:53:14 -0500")
On Monday, November 13 2017, I wrote:
> This patch series performs the conversion of the probe interfaces
> (generic, stap and dtrace) to C++, along with a few cleanups here and
> there to make the code conform better to our standards.
Sorry, it seems my git-format-patch messed up and generated a lot of
patches on my source tree. Please, ignore this thread. I will resubmit
the patches in a new thread.
> This series needs to be committed/tested as one single patch, because
> of inter-dependencies. However, in order to facilitate the review
> process, I decided to split things into logical units.
>
> The main changes are the conversion of 'struct probe' to 'class
> probe', and 'struct probe_ops' to 'class static_probe_ops'. Almost
> everything else in the patches are adjustments related to these
> modifications.
>
> It's important to say that 'class probe' contains the majority of the
> methods that were previously living inside 'struct probe_ops'.
> However, some methods are special in the sense the they don't act on a
> specific probe object, but generically on a probe type (like a
> factory). For that reason the 'class static_probe_ops' had to be
> created.
>
> Most methods in 'class probe' are pure virtual and need to be defined
> by the probe backend (stap or dtrace, for now). Other methods (e.g.,
> the 'enable' method) are virtual but non-pure and have a default,
> dummy version implemented on 'class probe' itself, because the concept
> of enabling a probe is not common to all types of probes.
>
> I've also taken the opportunity to convert a few uses of "VEC" to
> "std::vector", and to remove annoying spurious newlines from some
> places.
>
> The whole patch has been tested on BuildBot, without regressions.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-11-13 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 17:53 Sergio Durigan Junior
2017-11-13 17:53 ` [PATCH 2/2] Convert DTrace probe interface " Sergio Durigan Junior
2017-11-13 17:53 ` [PATCH 1/2] Convert SystemTap " Sergio Durigan Junior
2017-11-13 17:53 ` [PATCH 1/3] Convert generic " Sergio Durigan Junior
2017-11-13 17:58 ` Sergio Durigan Junior [this message]
2017-11-13 18:02 ` [PATCH 2/3] Convert SystemTap " Sergio Durigan Junior
2017-11-13 18:02 ` [PATCH 3/3] Convert DTrace " Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760aeoybv.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).