From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116016 invoked by alias); 13 Nov 2017 17:58:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115843 invoked by uid 89); 13 Nov 2017 17:58:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=act X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Nov 2017 17:58:14 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 700E9C04F2A5 for ; Mon, 13 Nov 2017 17:58:13 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47F2D80E0C for ; Mon, 13 Nov 2017 17:58:13 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Subject: [CANCEL] [PATCH 0/3] Convert probe interfaces to C++ (and perform some cleanups) References: <20171113175319.24280-1-sergiodj@redhat.com> Date: Mon, 13 Nov 2017 17:58:00 -0000 In-Reply-To: <20171113175319.24280-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Mon, 13 Nov 2017 12:53:14 -0500") Message-ID: <8760aeoybv.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00240.txt.bz2 On Monday, November 13 2017, I wrote: > This patch series performs the conversion of the probe interfaces > (generic, stap and dtrace) to C++, along with a few cleanups here and > there to make the code conform better to our standards. Sorry, it seems my git-format-patch messed up and generated a lot of patches on my source tree. Please, ignore this thread. I will resubmit the patches in a new thread. > This series needs to be committed/tested as one single patch, because > of inter-dependencies. However, in order to facilitate the review > process, I decided to split things into logical units. > > The main changes are the conversion of 'struct probe' to 'class > probe', and 'struct probe_ops' to 'class static_probe_ops'. Almost > everything else in the patches are adjustments related to these > modifications. > > It's important to say that 'class probe' contains the majority of the > methods that were previously living inside 'struct probe_ops'. > However, some methods are special in the sense the they don't act on a > specific probe object, but generically on a probe type (like a > factory). For that reason the 'class static_probe_ops' had to be > created. > > Most methods in 'class probe' are pure virtual and need to be defined > by the probe backend (stap or dtrace, for now). Other methods (e.g., > the 'enable' method) are virtual but non-pure and have a default, > dummy version implemented on 'class probe' itself, because the concept > of enabling a probe is not common to all types of probes. > > I've also taken the opportunity to convert a few uses of "VEC" to > "std::vector", and to remove annoying spurious newlines from some > places. > > The whole patch has been tested on BuildBot, without regressions. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/