From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117200 invoked by alias); 11 Feb 2016 21:28:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117185 invoked by uid 89); 11 Feb 2016 21:28:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2985, misconfigured X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Feb 2016 21:28:08 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D121F70032; Thu, 11 Feb 2016 21:28:06 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1BLS5fF031667 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 11 Feb 2016 16:28:06 -0500 From: Sergio Durigan Junior To: Simon Marchi Cc: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= , Pedro Alves , Subject: Re: [PATCH 1/3] gdb.trace: Save XML target description in tfile. References: <56BB34F2.5030403@redhat.com> <1455135521-21767-1-git-send-email-koriakin@0x04.net> <56BBB793.3080108@redhat.com> <56BBBB22.1050405@0x04.net> <56BCDABE.7080008@ericsson.com> X-URL: http://blog.sergiodj.net Date: Thu, 11 Feb 2016 21:28:00 -0000 In-Reply-To: <56BCDABE.7080008@ericsson.com> (Simon Marchi's message of "Thu, 11 Feb 2016 14:02:22 -0500") Message-ID: <8760xvhr8a.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00391.txt.bz2 On Thursday, February 11 2016, Simon Marchi wrote: > On 16-02-10 05:35 PM, Marcin Ko=C5=9Bcielnicki wrote: >> On 10/02/16 23:20, Pedro Alves wrote: >>> On 02/10/2016 08:18 PM, Marcin Ko=C5=9Bcielnicki wrote: >>>> gdb/ChangeLog: >>>> >>>> * ctf.c (ctf_write_tdesc): New function. >>>> (ctf_write_ops): Wire in ctf_write_tdesc. >>>> * tracefile-tfile.c (tfile_write_tdesc): New function. >>>> (tfile_write_ops): Wire in tfile_write_tdesc. >>>> * tracefile.c (trace_save): Call write_tdesc method. >>>> * tracefile.h (struct trace_file_write_ops): Add write_tdesc method. >>>> * xml-tdesc.c (target_fetch_description_xml): New function. >>>> * xml-tdesc.h: Add target_fetch_description_xml prototype. >>> >>> OK. >>> >>> Thanks, >>> Pedro Alves >>> >>=20 >> Thanks, pushed. >>=20 > > Hi Marcin, > > Did you get an email from Builbot about this patch? > > An unrelated patch did fail because of this one: > http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3021/steps/comp= ile%20gdb/logs/stdio > > It happens when you build without expat. Maybe this particular slave doe= sn't have expat-devel > installed, but others do. You can reproduce it locally by configuring wi= th --with-expat=3Dno or > --without-expat. This was my fault. I run two Fedora buildslaves for x86, and one of them did not have the i686 packages installed. Everything should be fine now. BTW, I am really interested in knowing if Marcin received an e-mail from BuildBot. Simon, did you receive an e-mail as well? > @Sergio: To ensure that we always test in the same conditions, perhaps we= could add --with-expat, > --with-python, and maybe others? Can it be done on a per-builder basis? This could be a good idea. One of the problems I have is ensure that all the buildslaves have a minimum set of packages installed for testing. I tried listing all the packages I could in the wiki: But it's not easy to guarantee that all of them are following this. Enforcing compliance through the use of some flags (--with-*) could help us to bring everybody up to speed. The only problem is that we'll see some failures happening when a buildslave is not configured properly, and that may seem like a failure introduced by a patch. But I'm guessing they'll be quick to fix. > This way, if the slave for a builder is mis-configured (doesn't have deve= lopment packages for > those), configure will fail right away. In an ideal world, to catch prob= lems like the current > one though, we should test gdb (at least see if it builds) with various c= ombinations of > with/without python, expat, etc. The problem is that we don't have enough buildslaves now to handle several combinations of flags. For now, I think it's enough to test the "normal" configuration. Thanks, --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/