From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] make "permanent breakpoints" per location and disableable
Date: Wed, 05 Nov 2014 06:37:00 -0000 [thread overview]
Message-ID: <8761eu8863.fsf@codesourcery.com> (raw)
In-Reply-To: <1415127790-15091-3-git-send-email-palves@redhat.com> (Pedro Alves's message of "Tue, 4 Nov 2014 19:03:09 +0000")
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
I go through this patch, and don't see anything wrong except this below,
> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
> index 118a37f..c383cd4 100644
> --- a/gdb/breakpoint.h
> +++ b/gdb/breakpoint.h
> @@ -193,12 +193,6 @@ enum enable_state
> automatically enabled and reset when the
> call "lands" (either completes, or stops
> at another eventpoint). */
> - bp_permanent /* There is a breakpoint instruction
> - hard-wired into the target's code. Don't
> - try to write another breakpoint
> - instruction on top of it, or restore its
> - value. Step over it using the
> - architecture's SKIP_INSN macro. */
> };
This causes a compilation error in guile/scm-breakpoint.c where
bp_permanent is in use.
../../../git/gdb/guile/scm-breakpoint.c: In function ‘bpscm_enable_state_to_string’:
../../../git/gdb/guile/scm-breakpoint.c:154:10: error: ‘bp_permanent’ undeclared (first use in this function)
case bp_permanent: return "permanent";
static const char *
bpscm_enable_state_to_string (enum enable_state enable_state)
{
switch (enable_state)
{
case bp_disabled: return "disabled";
case bp_enabled: return "enabled";
case bp_call_disabled: return "call_disabled";
case bp_permanent: return "permanent";
^^^^^^^^^^^^
default: return "unknown";
}
}
--
Yao (齐尧)
next prev parent reply other threads:[~2014-11-05 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 19:03 [PATCH 0/3] fix permanent breakpoints Pedro Alves
2014-11-04 19:03 ` [PATCH 2/3] make "permanent breakpoints" per location and disableable Pedro Alves
2014-11-05 6:37 ` Yao Qi [this message]
2014-11-12 10:55 ` Pedro Alves
2014-11-20 16:41 ` [RFA] Always consider infcall breakpoints as non-permanent Joel Brobecker
2014-11-21 11:38 ` Pedro Alves
2014-11-23 10:44 ` Joel Brobecker
2014-11-04 19:03 ` [PATCH 1/3] add a default method for gdbarch_skip_permanent_breakpoint Pedro Alves
2014-11-04 19:03 ` [PATCH 3/3] fix skipping permanent breakpoints Pedro Alves
2014-11-05 12:26 ` Yao Qi
2014-11-07 19:53 ` Pedro Alves
2014-11-12 0:54 ` Yao Qi
2014-11-12 10:53 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761eu8863.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).