From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26358 invoked by alias); 10 Oct 2014 16:38:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26285 invoked by uid 89); 10 Oct 2014 16:38:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 16:38:49 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9AGcgos012362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Oct 2014 16:38:43 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGcfkT007266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Oct 2014 16:38:42 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s9AGcdIc022521; Fri, 10 Oct 2014 16:38:39 GMT Received: from termi.oracle.com (/10.175.211.52) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Oct 2014 09:38:39 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/9] New commands `enable probe' and `disable probe'. References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-4-git-send-email-jose.marchesi@oracle.com> <87mw9g4s8q.fsf@redhat.com> Date: Fri, 10 Oct 2014 16:38:00 -0000 In-Reply-To: <87mw9g4s8q.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 30 Sep 2014 19:13:09 -0400") Message-ID: <8761frev7u.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00254.txt.bz2 Hi Sergio. > This patch adds the above-mentioned commands to the generic probe abstraction > implemented in probe.[ch]. The effects associated to enabling or disabling a > probe depend on the type of probe being handled, and is triggered by invoking > two back-end hooks in `probe_ops'. > > In case some particular probe type does not support the notion of enabling > and/or disabling, the corresponding fields on `probe_ops' can be initialized > to NULL. This is the case of SystemTap probes. Thanks for the patch, Jose. Comments below, as usual. I agree/comply with all these comments :)