From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16812 invoked by alias); 18 Jan 2014 20:42:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16798 invoked by uid 89); 18 Jan 2014 20:42:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: hera.aquilenet.fr Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Jan 2014 20:42:48 +0000 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C543A1A5F; Sat, 18 Jan 2014 21:42:44 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r4innMSQrTap; Sat, 18 Jan 2014 21:42:44 +0100 (CET) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 62A631831; Sat, 18 Jan 2014 21:42:44 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Doug Evans Cc: Eli Zaretskii , "gdb-patches\@sourceware.org" Subject: Re: [PATCH v1 02/36] Guile extension language: doc additions References: <52b9da59.64ab440a.0b0b.7e1c@mx.google.com> <83ha9w68av.fsf@gnu.org> <87sit4kb1t.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Niv=C3=B4se?= an 222 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Sat, 18 Jan 2014 20:42:00 -0000 In-Reply-To: (Doug Evans's message of "Sat, 18 Jan 2014 12:16:53 -0800") Message-ID: <8761phqaws.fsf@gnu.org> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-01/txt/msg00703.txt.bz2 Doug Evans skribis: > On Fri, Jan 3, 2014 at 1:30 PM, Ludovic Court=C3=A8s wrote: >>>> +The optional @var{errors} argument is either @code{"strict"} >>>> +or @code{"replace"}. A value of @code{"strict"} corresponds to >>>> +Guile's @code{SCM_FAILED_CONVERSION_ERROR} and a value of @code{"repl= ace"} >>>> +corresponds to Guile's @code{SCM_FAILED_CONVERSION_QUESTION_MARK}. >>> >>> Suggest a cross-reference to Guile documentation here. >> >> Agreed. Also, Guile talks of =E2=80=9Cconversion strategy=E2=80=9D and = =E2=80=9Cconversion >> error handler=E2=80=9D, with values =E2=80=98error=E2=80=99, =E2=80=98su= bstitute=E2=80=99, and =E2=80=98escape=E2=80=99 (at the >> Scheme level), and I=E2=80=99d recommend sticking to those names and ter= minology. > > The values chosen were to be consistent with the python support. > OTOH I *do* like being more consistent with the particular extension > language at hand. > I've tentatively changes things to use "error" and "substitute". > Question: How about exporting the SCM_FAILED_CONVERSION_* constants > and using those instead? > > E.g, (value->string foo #:errors SCM_FAILED_CONVERSION_ERROR) ? I=E2=80=99d rather use a symbol: (value->string foo #:conversion-strategy 'error) So that has to be converted in C but I think that=E2=80=99s OK. (I just noticed that Guile=E2=80=99s =E2=80=98pointer->string=E2=80=99, whi= ch is similar, lacks this argument.) > Also, in the same spirit of naming things with preference to being > more consistent with the extension language at hand than being more > consistent across all extension languages, does anyone mind if I > rename the "guile-interactive" command to "guile-repl"? Fine with me. Thanks, Ludo=E2=80=99.