From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24040 invoked by alias); 15 Jan 2014 21:28:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23992 invoked by uid 89); 15 Jan 2014 21:28:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 21:28:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FLSQ0C025219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jan 2014 16:28:26 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0FLSPmZ008355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 15 Jan 2014 16:28:25 -0500 From: Tom Tromey To: Sanimir Agovic Cc: palves@redhat.com, xdje42@gmail.com, gdb-patches@sourceware.org, keven.boell@intel.com Subject: Re: [PATCH v4 04/13] vla: enable sizeof operator for indirection References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-5-git-send-email-sanimir.agovic@intel.com> Date: Wed, 15 Jan 2014 21:28:00 -0000 In-Reply-To: <1387282678-3847-5-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Tue, 17 Dec 2013 13:17:49 +0100") Message-ID: <8761ploryf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00569.txt.bz2 >>>>> "Sanimir" == Sanimir Agovic writes: Sanimir> 2013-10-18 Sanimir Agovic Sanimir> Keven Boell Sanimir> * eval.c (evaluate_subexp_for_sizeof): Create a indirect value and Sanimir> retrieve the dynamic type size. I neglected to mention it in the previous patch, but when changing one case in a function like this, that consists of little but a big switch, it's normal to mention the case, like: * eval.c (evaluate_subexp_for_sizeof) : ... The patch looks good. Tom