From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28804 invoked by alias); 22 Aug 2018 11:39:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28795 invoked by uid 89); 22 Aug 2018 11:39:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Aug 2018 11:39:28 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA6DD804BAAD; Wed, 22 Aug 2018 11:39:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 118B01D087; Wed, 22 Aug 2018 11:39:25 +0000 (UTC) Subject: Re: [RFC] mi: print frame architecture when printing frames on an MI channel To: Jan Vrany , gdb-patches@sourceware.org References: <15de754b-78b0-8eaa-6c26-6f14077fa0a9@redhat.com> <20180822094238.22304-1-jan.vrany@fit.cvut.cz> From: Pedro Alves Message-ID: <8772378f-c4a9-fd3b-0364-bf34fdbf4a8f@redhat.com> Date: Wed, 22 Aug 2018 11:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180822094238.22304-1-jan.vrany@fit.cvut.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00525.txt.bz2 Merged, thanks. Pedro Alves On 08/22/2018 10:42 AM, Jan Vrany wrote: > When printing frames on an MI channel also print frame architecture > like in: > > (gdb) > -stack-list-frames 3 3 > ^done,stack= > [frame={level="3",addr="0x000107a4",func="foo", > file="recursive2.c",fullname="/home/foo/bar/recursive2.c", > line="14",arch="i386:x86_64"}] > (gdb) > > This is useful for MI clients that need to know the architecture in order > to perform further analysis, for example to use their own disassembler to > analyze machine code. > > gdb/Changelog: > > * stack.c (print_frame): Print frame architecture when printing on > an MI output. > * NEWS: Mention new "arch" attribute in frame output. > > gdb/testsuite/Changelog > > * lib/mi-support.exp (mi_expect_stop): Update regexp to > accommodate new "arch" field in frame output. > * gdb.mi/mi-return.exp: Likewise. > * gdb.mi/mi-stack.exp: Likewise. > * gdb.mi/mi-syn-frame.exp: Likewise. > * gdb.mi/user-selected-context-sync.exp: Likewise. > > gdb/doc/Changelog > > * gdb.texinfo (The -stack-list-frames Command): Update description > to mention "arch". > Update MI examples thorough the document to contain "arch" in frame > output.