From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 92D8D3858D35 for ; Mon, 24 Jun 2024 15:11:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92D8D3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92D8D3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719241876; cv=none; b=oszJtE4D2rlwMmlDqiStJmZ+fbTSn6Wtp8gJGADRcplnZkHtEMsYdEMY+20gWKFEfIZRVlteI/SaNt/h8IbhEzqbrk4mFnZWJRx6Keh8kRS5HF54SvRXxQhRw4ceoFcfQ10uuCUwpZP6nI1SufLQSdESqhuHgHLasWzM6yN9Dfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719241876; c=relaxed/simple; bh=UfbQm+Vp9KVUjy2RED2efAs2NveHCBeAZGgjh8QSLk0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JNNOGAJBHA9rhr8dYfUwmcFdGpJGiYZU0xSKCLvNyy/kQY7O9pm0ff8KBM74VAsuAF90aXHX68o82qeNWCPquYeNN1mYqQtPZw5YY22knBzNTPMCC2NgQcdp2/TqFFO6cOSHiyAa3HayznaQ84GZwdVNe4PSMZ+JzU9Ic66eztw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7eee7728b00so166949239f.3 for ; Mon, 24 Jun 2024 08:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1719241873; x=1719846673; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4171h/tBsdXpyiLBJQ3Htc8C/rsr1n3J/7JhJ4VVlyA=; b=hl2ZKjcv5v4VMa9yUTdUfL2li/54ylY1Q0MEhq3VIbBH/AtdhiKPkiPQDOpkoBXHCc 4cNX8FeidzwJr8pl/uFWYKsJQ3WNBWg7fBw+elaEdkuaN2ZvHhcmQ1U9sy8VLjyfcOmn H8G6g4GfIVNQVEsts/+VfIAe2xzZs+XJcUO/9+YOUz45718mAF6lK8/LAGg4k+lUg09d 0IbXc/VrnmZhmcpbQkXZoTXOowS1iwW7QAhVIBCh3wsv6mzpyi034g/8sRRRSmBQbw2x bXkW35ex6EsqgAtZbN6pEnAfXkQw8x9I2ww9vYeP0CbPDvZULXeuJdGPa/kTfPCIfPXu l+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719241873; x=1719846673; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4171h/tBsdXpyiLBJQ3Htc8C/rsr1n3J/7JhJ4VVlyA=; b=bpp4q+sW/SoK1FxfbWpGQzaox74MR698+3t/4k3LZ3+TEQUo6IScoXmJgtj/VlRqSX 81DDy4Dq8l+mNPqZ8n8ux7wdAO3RchIsbMK4dCM6RXSzhYrd35e3lsQL6svETHmGHVXT KJDUC7MBhzAF7/NDFjCT0151RSD6Nv1qgIxW2EDd9pt1MxGCpNO2MoeO1K9OlCpRmlll 0mEFe9CAHfzAGSJj7N0MkeERuVVwS04k78FPGZnJNS6qHVOl1ywImBiFEUWQX/+p0dMZ 3i0zjb9/MAiOBkvTWaWd3L+anwdEKfgxrPtmidpCZFYthG8A0aY51UmxDozOwPVHSOwB HIdA== X-Forwarded-Encrypted: i=1; AJvYcCVop89ggFZi3pbRBtsoWcQcZkr9RyV/h1s0HzEaCC73pvx7HHcUKjz/xokKe3XNW7T1ZnuX4u0ktntanaD/EPAzBfxGlTIh2+3dFQ== X-Gm-Message-State: AOJu0YzKJXCFgy1ievi0hVYV9oqaw85to+G2MSIJYcmqLW2IS1Xq/Src ZJh+FmEikLKFkS1Kgi8jjtcRu38mf8rxucx/IfyEvv0BOA4Z/APAbz3V8K+i8br7bgFHMBKzgPk = X-Google-Smtp-Source: AGHT+IHw8d1qVyL/ISAM72r/X94HakL9eiOVjtBKs7/cX9a7dCK3JoS5NCT/Cz5zoMvDpgH8t59YgA== X-Received: by 2002:a05:6602:2dcc:b0:7eb:f503:e5ef with SMTP id ca18e2360f4ac-7f3a75b3011mr527355739f.14.1719241873661; Mon, 24 Jun 2024 08:11:13 -0700 (PDT) Received: from murgatroyd (97-122-118-144.hlrn.qwest.net. [97.122.118.144]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ba088f18a8sm109223173.31.2024.06.24.08.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 08:11:13 -0700 (PDT) From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/8] Remove obstack allocation of hash tables In-Reply-To: <48b5a886-cad6-4945-9baa-8b28fb7d2bd1@redhat.com> (Keith Seitz's message of "Tue, 18 Jun 2024 14:03:48 -0700") References: <20240605-hash-tab-no-obstack-v1-0-aa10f4d46a8f@adacore.com> <48b5a886-cad6-4945-9baa-8b28fb7d2bd1@redhat.com> X-Attribution: Tom Date: Mon, 24 Jun 2024 09:11:11 -0600 Message-ID: <877ceev0j4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Keith" == Keith Seitz writes: Keith> I am biased -- I've always had a fair amount of disdain for obstacks -- Keith> so I really am pleased to see this series. Yeah. I have mixed feelings about them, for PODs they seem ok-ish; but for hash tables I never liked them. Keith> Having looked through it, and having refreshed my memory on a Keith> few things, this series LGTM. I encourage you to commit it. Thanks, I'm checking it in. Tom