From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4EA393858D28 for ; Mon, 8 Apr 2024 09:17:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EA393858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4EA393858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712567823; cv=none; b=BconV3VPnzD6786Nl+mTark9mZGYVHoNKrrhmlCxpQ4cMkfHSATRYpeEEYvN5KX8idZK8NMWnSyKayCgHYgOgROEJ/gAPcKhyufU7VZIMHmrKBAhO8BzO6DbJnwjA+UOSRlx3GuIn6Z+z7YvcGLPnwFLhSvVslkQRN7H25zmhn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712567823; c=relaxed/simple; bh=nYDKmMFHq+wxVL6VvJ2WS6vspzVKWTYr1m4Ccj4RT5g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PDjKrytS+kPzjuH8zaQCApAjnHw4kkLKTfBP5LNz6mAqMVM9j6UpVl5+woRI3AuqOSS/8s9dASNGMuiY/E20qLcpP2MjMt4OHZhTn4OuPkBGMr+OZu3nqn6oB3oTRvxJLhiSrUyG2GdO0RL8ytqHs/zv+GAK/kSOO4ydjkJILro= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712567820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zz3Bdb/7HC5QeuYJWEdygc2rB5kWBhxPHD44HkIKPCs=; b=DAGe5va1WAkf2fRG+OnEhT2MUTlpRkS7rLmDUvaXAUEAYAZQmE88Ed3nb2TkE3NKTRGIo/ n4TB9wRrhhyT+JPjZ6k0XAqAL4A/JeVG40giWZTqYtAq8TjAw21ehAzP6Urys05axBaW2Q BkDRDVObuJ7AyL0tVwrQi9OIYPYSIuw= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-6yJuxL09M9uMRu4Vdao86g-1; Mon, 08 Apr 2024 05:16:58 -0400 X-MC-Unique: 6yJuxL09M9uMRu4Vdao86g-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a5199cc13b2so248936466b.0 for ; Mon, 08 Apr 2024 02:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712567817; x=1713172617; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zz3Bdb/7HC5QeuYJWEdygc2rB5kWBhxPHD44HkIKPCs=; b=nJtxuLXU8d7mLWuWQnnW/sAwD4eercYZlJxGeVZBI27t3HkjLl3EYVHfzJY+e/5fjA WdnEfTy3/pbb37rFIPlddrDNRDk9Kqm+VrwcPY/GKTbpFotLWa6WiVTEN+GTpb0B23lB 1+W/QKuWBYcx48vsXHupvVW1QjqiMPQcHvOs0oEQLIg2VtZ+rwO2kB+BWGOKGnIK3rnO 8Sv43rTYPMzhsFvXBrtiutw8OfECZ4HZmX6VJOpFBLP9oGb+o03VGVI1DWczUdhMn4M/ 4pfJmKv5rCJpWeL+Oyw8eyryfm4UXanTAmb+rrkg05WZxS3Dn1jgsZLnJPdqCmHX1ksy JUnA== X-Forwarded-Encrypted: i=1; AJvYcCVWZUlzl9/30RLYWl4QYiVQEr33wWcnAcMXez6Ai6h+InGFBLXvye/+rPRhzXUHPLbUNpfaRwfzRzzDNoKGiPwNDPbp4sAA96r5qw== X-Gm-Message-State: AOJu0YxvGiO2MBblmrkJmnWHu/6/WFqfX/PyVF6libTHvXTM5bsfms2t MZtZAdUQqm4F9CxlgALTI7MvOBDBX1IHFOS33MZqU9uACXrcbwlddcL9DDcnd7gg2xyl0KGEH8g Qjx8VfdetlfiEIRDlgRRDw0pJMgnG/KPRREOgLh89b14XlQnyam4BnPx0a3w= X-Received: by 2002:a17:907:7203:b0:a51:d475:aca3 with SMTP id dr3-20020a170907720300b00a51d475aca3mr2648673ejc.16.1712567817402; Mon, 08 Apr 2024 02:16:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECv9WlsY7jUA5DJPmSaAzA5phnpY3XDOT89WJovXoyizbJ+aJdJjNf+0AZFJtuB6o5EYx5PA== X-Received: by 2002:a17:907:7203:b0:a51:d475:aca3 with SMTP id dr3-20020a170907720300b00a51d475aca3mr2648654ejc.16.1712567816644; Mon, 08 Apr 2024 02:16:56 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id i19-20020a170906265300b00a4e58c74c9fsm4178335ejc.6.2024.04.08.02.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 02:16:56 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv2 6/6] gdb/build: apply silent-rules.mk to the data-directory Makefile.in In-Reply-To: References: <97d0a17d1cc2414b98d1dd6bd0344748400b30c4.1712422921.git.aburgess@redhat.com> Date: Mon, 08 Apr 2024 10:16:55 +0100 Message-ID: <877ch82ozc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: > On 2024-04-06 13:03, Andrew Burgess wrote: > >> I've not managed to completely silence all of the recipe output, the >> mkinstalldirs command outputs some diagnostic text which looks like >> this: >> >> GEN stamp-python >> mkdir -p -- ./python/gdb >> mkdir -p -- ./python/gdb/command >> mkdir -p -- ./python/gdb/dap >> mkdir -p -- ./python/gdb/function >> mkdir -p -- ./python/gdb/printer > > The output of these targets is a bit funny, "stamp-something". It's as > if the stamp file was the final artefact we're interested in, when in > fact it's a build system detail. Not a problem for me though. Indeed. We already have ECHO_GEN_XML_BUILTIN, ECHO_GEN_XML_BUILTIN_GENERATED, and ECHO_INIT_C which are used as alternatives to mentioning various 'stamp-*' targets. I didn't do this because adding more and more new ECHO_GEN_* defines just seemed unnecessary; seeing the stamp-* doesn't bother me, and this is just something developers see, it's not for end users, so my expectation is that folk will be able to ask, or dig into it if they really care. Plus, for some of the rules, like 'stamp-python' and 'stamp-guile', where many things are done, it's not obvious what you'd replace the 'stamp-*' with. That all said, if someone came along after and did add some custom ECHO_GEN_* defines, I'm not going to stop them. Thanks, Andrew