From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 8F9543858D34; Mon, 11 Mar 2024 23:13:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F9543858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F9543858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710198789; cv=none; b=R5Px6X9sEAX1QwbxnRknERH6txs3FzGUvkLTA+M5Fg5pQHjt3zFn7HX+KmZ8tMp1ExZPmS4U+0RrfOmiYnu1R71IWFMXKnyg4iw4FwnPvvI2JLOTyVgJoLQAeSsANxkUtkH1rprnDW5zk8xTVbMo+dJZACNs0ohpFdcBx2Tig9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710198789; c=relaxed/simple; bh=NUs9Xl5LiqASTyIaj3UgffcyWSdkRMtHQ/EWsasc7I0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=aIJUVohL48KofWsPDIGVVdefBdF+XxcM25A7SnROLBobj40OM6kN9NqcBe6d8kUMF4j6fPoYp8anXdpZSCS0sqpijJ1KK6fQ2mdisim10yJAn3mxANA1Z35bhh7CROlK1bwwdZ82qU/fAUB8SAMK9p24gnCt+pd2w/rSnn4+0ac= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: Tom Tromey Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] Sync libbacktrace from gcc [PR31327] In-Reply-To: <87cys0pt31.fsf@tromey.com> (Tom Tromey's message of "Mon, 11 Mar 2024 11:38:10 -0600") Organization: Gentoo References: <20240311172112.2435201-1-sam@gentoo.org> <87cys0pt31.fsf@tromey.com> User-Agent: mu4e 1.12.0; emacs 30.0.50 Date: Mon, 11 Mar 2024 23:12:59 +0000 Message-ID: <877ci8mkg4.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Tom Tromey writes: >>>>>> "Sam" == Sam James writes: > > Sam> Note that this includes Nick's fix from edf64cd235f5ecb3725e7cf1ff83bbdb6dd53340 which > Sam> landed upstream a bit differently as r13-1566-g9ed57796235abc in GCC. > > Sam> This pulls in libbacktrace as of r14-9404-gc775a030af9cad in GCC trunk. > > Thank you. If this makes it identical to gcc then I think it's fine. > If not perhaps posting the diff would be helpful. Thanks. I've pushed it with a tiny diff compared to gcc after discussing it on IRC (Simon pointed out the difference): --- a/libbacktrace/configure.ac.gcc +++ b/libbacktrace/configure.ac.binutils @@ -84,8 +84,6 @@ AM_CONDITIONAL(HAVE_DWZ, test "$DWZ" != "") LT_INIT AM_PROG_LIBTOOL -AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test x$enable_darwin_at_rpath = xyes]) - AC_SYS_LARGEFILE backtrace_supported=yes .. with the corresponding regen. It's described in the commit message -- it's from a top-level Darwin change which would need other syncing that is best done separately. > > Approved-By: Tom Tromey > > Tom best, sam --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZe+P/F8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAVjQEAmnf6JRvvKN34+iS19tKhVh9vCtJgBfdz14Ui gPR9p2gBAI9ZlDlE5UuaqQdzj3PqpXwKvY7pmVWqNYJpovnhuDYI =cma/ -----END PGP SIGNATURE----- --=-=-=--